Replace hardcoded maintainers with dynamic GitHub API fetch#18823
Merged
Replace hardcoded maintainers with dynamic GitHub API fetch#18823
Conversation
Contributor
|
@Copilot Thank you for the contribution! Could you fix the following issue(s)? ⚠ Invalid PR templateThis PR does not appear to have been filed using the MLflow PR template. Please copy the PR template from here and fill it out. |
- Use github.rest.repos.listCollaborators with pagination - Filter by role_name='admin' or 'maintain' - Add console logging for debugging - Format code with prettier Co-authored-by: harupy <17039389+harupy@users.noreply.github.com>
The github.rest.repos.listCollaborators API requires repository access. Adding contents:read permission ensures the workflow has the necessary permissions to fetch the collaborators list. Co-authored-by: harupy <17039389+harupy@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Remove hardcoded core maintainers and fetch dynamically
Replace hardcoded maintainers with dynamic GitHub API fetch
Nov 13, 2025
8591027 to
446dc37
Compare
harupy
reviewed
Nov 13, 2025
|
|
||
| console.log("Core maintainers (admin or maintain role):", coreMaintainers); | ||
|
|
||
| const CORE_MAINTAINERS = new Set(coreMaintainers); |
Member
There was a problem hiding this comment.
Can we rename CORE_MAINTAINERS with coreMaintainers?
Contributor
Author
There was a problem hiding this comment.
Done in fc7681d. Renamed to coreMaintainers for consistency.
harupy
reviewed
Nov 13, 2025
harupy
reviewed
Nov 13, 2025
- Extract logic into getCoreMaintainers() function that returns Set - Rename CORE_MAINTAINERS to coreMaintainers for consistency - Maintain all existing functionality Co-authored-by: harupy <17039389+harupy@users.noreply.github.com> Signed-off-by: harupy <17039389+harupy@users.noreply.github.com>
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: harupy <17039389+harupy@users.noreply.github.com>
fc7681d to
f44953c
Compare
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: harupy <17039389+harupy@users.noreply.github.com>
847ca86 to
7b3eef0
Compare
harupy
reviewed
Nov 13, 2025
Signed-off-by: Harutaka Kawamura <hkawamura0130@gmail.com>
harupy
approved these changes
Nov 13, 2025
Tian-Sky-Lan
pushed a commit
to Tian-Sky-Lan/mlflow
that referenced
this pull request
Nov 24, 2025
…8823) Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> Signed-off-by: Harutaka Kawamura <hkawamura0130@gmail.com> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: harupy <17039389+harupy@users.noreply.github.com> Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: Harutaka Kawamura <hkawamura0130@gmail.com> Signed-off-by: Tian Lan <sky.blue266000@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues/PRs
#xxx
What changes are proposed in this pull request?
The maintainer approval workflow used a hardcoded list of maintainer usernames. This required manual updates when maintainers changed and could become stale.
How is this PR tested?
Validated filtering logic with mock data to ensure correct role-based filtering and approval checking.
Does this PR require documentation update?
Release Notes
Is this a user-facing change?
What component(s), interfaces, languages, and integrations does this PR affect?
Components
area/tracking: Tracking Service, tracking client APIs, autologgingarea/models: MLmodel format, model serialization/deserialization, flavorsarea/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registryarea/scoring: MLflow Model server, model deployment tools, Spark UDFsarea/evaluation: MLflow model evaluation features, evaluation metrics, and evaluation workflowsarea/gateway: MLflow AI Gateway client APIs, server, and third-party integrationsarea/prompts: MLflow prompt engineering features, prompt templates, and prompt managementarea/tracing: MLflow Tracing features, tracing APIs, and LLM tracing functionalityarea/projects: MLproject format, project running backendsarea/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev serverarea/build: Build and test infrastructure for MLflowarea/docs: MLflow documentation pagesHow should the PR be classified in the release notes? Choose one:
rn/none- No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" sectionrn/breaking-change- The PR will be mentioned in the "Breaking Changes" sectionrn/feature- A new user-facing feature worth mentioning in the release notesrn/bug-fix- A user-facing bug fix worth mentioning in the release notesrn/documentation- A user-facing documentation change worth mentioning in the release notesShould this PR be included in the next patch release?
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.