Clean up the Deep Learning landing page#18820
Conversation
Signed-off-by: Ben Wilson <benjamin.wilson@databricks.com>
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the Deep Learning landing page to be more concise and accessible while fixing display issues with framework logos.
- Simplified the landing page from a verbose, collapsible-heavy format to a clean, modern card-based layout
- Fixed SVG logo rendering issues for spaCy and TensorFlow by adding proper width/height attributes
- Modernized the page structure using TileCard and FeatureHighlights components
Reviewed Changes
Copilot reviewed 1 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| docs/static/images/logos/spacy-logo.svg | Added width and height attributes to fix logo display |
| docs/static/images/logos/TensorFlow-logo.svg | Modified viewBox and added width/height attributes to properly crop and display the logo |
| docs/docs/classic-ml/deep-learning/index.mdx | Refactored from verbose content with extensive collapsibles to a concise, card-based landing page with clear navigation to framework-specific guides |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Documentation preview for b87062d is available at: Changed Pages (1)
More info
|
There was a problem hiding this comment.
The logo was missing sizing criteria in the .svg metadata meaning that it couldn't be included in our components. The modification was to add the missing critical metadata so that the .svg didn't get css overrides by our components that resized it to 0px x 0px due to overflow of the flex container.
There was a problem hiding this comment.
the spacy and tensorflow logos needs some padding like the huggingface logo
There was a problem hiding this comment.
I'll see if I can make the background transparent on all of them. They've been like this for years.
There was a problem hiding this comment.
Looks like we had an inline CSS prop on these... adjusted for proper layout in latest push!
| /> | ||
| <TileCard | ||
| image="/images/logos/spacy-logo.svg" | ||
| title="spaCy Guide" |
There was a problem hiding this comment.
Yeah I'll handle this in a separate PR (delisting it as a 'named' flavor and removing it from the tile card entry)
Signed-off-by: Ben Wilson <benjamin.wilson@databricks.com>
| /* Keras logo - may have dark elements */ | ||
| [data-theme='dark'] .tileCard[href*='keras'] .tileImage { | ||
| filter: invert(1) hue-rotate(180deg); | ||
| background: transparent; | ||
| } |
There was a problem hiding this comment.
Will revert the color inversion for this logo :)
harupy
left a comment
There was a problem hiding this comment.
LGTM once https://github.com/mlflow/mlflow/pull/18820/files#r2521720601 is addressed!
Signed-off-by: Ben Wilson <benjamin.wilson@databricks.com>
Signed-off-by: Ben Wilson <benjamin.wilson@databricks.com> Signed-off-by: Tian Lan <sky.blue266000@gmail.com>




🛠 DevTools 🛠
Install mlflow from this PR
For Databricks, use the following command:
Related Issues/PRs
#xxxWhat changes are proposed in this pull request?
Refine the landing page for DL. Fix some invalid logos.
How is this PR tested?
Does this PR require documentation update?
Release Notes
Is this a user-facing change?
What component(s), interfaces, languages, and integrations does this PR affect?
Components
area/tracking: Tracking Service, tracking client APIs, autologgingarea/models: MLmodel format, model serialization/deserialization, flavorsarea/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registryarea/scoring: MLflow Model server, model deployment tools, Spark UDFsarea/evaluation: MLflow model evaluation features, evaluation metrics, and evaluation workflowsarea/gateway: MLflow AI Gateway client APIs, server, and third-party integrationsarea/prompts: MLflow prompt engineering features, prompt templates, and prompt managementarea/tracing: MLflow Tracing features, tracing APIs, and LLM tracing functionalityarea/projects: MLproject format, project running backendsarea/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev serverarea/build: Build and test infrastructure for MLflowarea/docs: MLflow documentation pagesHow should the PR be classified in the release notes? Choose one:
rn/none- No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" sectionrn/breaking-change- The PR will be mentioned in the "Breaking Changes" sectionrn/feature- A new user-facing feature worth mentioning in the release notesrn/bug-fix- A user-facing bug fix worth mentioning in the release notesrn/documentation- A user-facing documentation change worth mentioning in the release notesShould this PR be included in the next patch release?
Yesshould be selected for bug fixes, documentation updates, and other small changes.Noshould be selected for new features and larger changes. If you're unsure about the release classification of this PR, leave this unchecked to let the maintainers decide.What is a minor/patch release?
Bug fixes, doc updates and new features usually go into minor releases.
Bug fixes and doc updates usually go into patch releases.