Skip to content

Clean up the Deep Learning landing page#18820

Merged
BenWilson2 merged 3 commits intomlflow:masterfrom
BenWilson2:fix-dl-docs
Nov 13, 2025
Merged

Clean up the Deep Learning landing page#18820
BenWilson2 merged 3 commits intomlflow:masterfrom
BenWilson2:fix-dl-docs

Conversation

@BenWilson2
Copy link
Member

@BenWilson2 BenWilson2 commented Nov 13, 2025

🛠 DevTools 🛠

Open in GitHub Codespaces

Install mlflow from this PR

# mlflow
pip install git+https://github.com/mlflow/mlflow.git@refs/pull/18820/merge
# mlflow-skinny
pip install git+https://github.com/mlflow/mlflow.git@refs/pull/18820/merge#subdirectory=libs/skinny

For Databricks, use the following command:

%sh curl -LsSf https://raw.githubusercontent.com/mlflow/mlflow/HEAD/dev/install-skinny.sh | sh -s pull/18820/merge

Related Issues/PRs

#xxx

What changes are proposed in this pull request?

Refine the landing page for DL. Fix some invalid logos.

How is this PR tested?

  • Existing unit/integration tests
  • New unit/integration tests
  • Manual tests

Does this PR require documentation update?

  • No. You can skip the rest of this section.
  • Yes. I've updated:
    • Examples
    • API references
    • Instructions

Release Notes

Is this a user-facing change?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release notes for MLflow users.

What component(s), interfaces, languages, and integrations does this PR affect?

Components

  • area/tracking: Tracking Service, tracking client APIs, autologging
  • area/models: MLmodel format, model serialization/deserialization, flavors
  • area/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registry
  • area/scoring: MLflow Model server, model deployment tools, Spark UDFs
  • area/evaluation: MLflow model evaluation features, evaluation metrics, and evaluation workflows
  • area/gateway: MLflow AI Gateway client APIs, server, and third-party integrations
  • area/prompts: MLflow prompt engineering features, prompt templates, and prompt management
  • area/tracing: MLflow Tracing features, tracing APIs, and LLM tracing functionality
  • area/projects: MLproject format, project running backends
  • area/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev server
  • area/build: Build and test infrastructure for MLflow
  • area/docs: MLflow documentation pages

How should the PR be classified in the release notes? Choose one:

  • rn/none - No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" section
  • rn/breaking-change - The PR will be mentioned in the "Breaking Changes" section
  • rn/feature - A new user-facing feature worth mentioning in the release notes
  • rn/bug-fix - A user-facing bug fix worth mentioning in the release notes
  • rn/documentation - A user-facing documentation change worth mentioning in the release notes

Should this PR be included in the next patch release?

Yes should be selected for bug fixes, documentation updates, and other small changes. No should be selected for new features and larger changes. If you're unsure about the release classification of this PR, leave this unchecked to let the maintainers decide.

What is a minor/patch release?
  • Minor release: a release that increments the second part of the version number (e.g., 1.2.0 -> 1.3.0).
    Bug fixes, doc updates and new features usually go into minor releases.
  • Patch release: a release that increments the third part of the version number (e.g., 1.2.0 -> 1.2.1).
    Bug fixes and doc updates usually go into patch releases.
  • Yes (this PR will be cherry-picked and included in the next patch release)
  • No (this PR will be included in the next minor release)

Signed-off-by: Ben Wilson <benjamin.wilson@databricks.com>
@github-actions github-actions bot added v3.6.1 area/docs Documentation issues rn/documentation Mention under Documentation Changes in Changelogs. labels Nov 13, 2025
@BenWilson2 BenWilson2 requested a review from Copilot November 13, 2025 02:30
@BenWilson2 BenWilson2 added the team-review Trigger a team review request label Nov 13, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the Deep Learning landing page to be more concise and accessible while fixing display issues with framework logos.

  • Simplified the landing page from a verbose, collapsible-heavy format to a clean, modern card-based layout
  • Fixed SVG logo rendering issues for spaCy and TensorFlow by adding proper width/height attributes
  • Modernized the page structure using TileCard and FeatureHighlights components

Reviewed Changes

Copilot reviewed 1 out of 3 changed files in this pull request and generated no comments.

File Description
docs/static/images/logos/spacy-logo.svg Added width and height attributes to fix logo display
docs/static/images/logos/TensorFlow-logo.svg Modified viewBox and added width/height attributes to properly crop and display the logo
docs/docs/classic-ml/deep-learning/index.mdx Refactored from verbose content with extensive collapsibles to a concise, card-based landing page with clear navigation to framework-specific guides

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 13, 2025

Documentation preview for b87062d is available at:

Changed Pages (1)
More info
  • Ignore this comment if this PR does not change the documentation.
  • The preview is updated when a new commit is pushed to this PR.
  • This comment was created by this workflow run.
  • The documentation was built by this workflow run.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what changed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logo was missing sizing criteria in the .svg metadata meaning that it couldn't be included in our components. The modification was to add the missing critical metadata so that the .svg didn't get css overrides by our components that resized it to 0px x 0px due to overflow of the flex container.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These logos look like this in dark mode:

image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the spacy and tensorflow logos needs some padding like the huggingface logo

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll see if I can make the background transparent on all of them. They've been like this for years.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All 4 fixed!

Copy link
Member

@harupy harupy Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On mobile, it looks like this. Can we adjust the tile component?

image

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we had an inline CSS prop on these... adjusted for proper layout in latest push!

/>
<TileCard
image="/images/logos/spacy-logo.svg"
title="spaCy Guide"
Copy link
Member

@harupy harupy Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if we still want to highlight spacy. It's dead:

image

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I'll handle this in a separate PR (delisting it as a 'named' flavor and removing it from the tile card entry)

Signed-off-by: Ben Wilson <benjamin.wilson@databricks.com>
Comment on lines +104 to +108
/* Keras logo - may have dark elements */
[data-theme='dark'] .tileCard[href*='keras'] .tileImage {
filter: invert(1) hue-rotate(180deg);
background: transparent;
}
Copy link
Member

@harupy harupy Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't look like keras. The keras logo looks fine on both light and dark theme.

image

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will revert the color inversion for this logo :)

Copy link
Member

@harupy harupy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signed-off-by: Ben Wilson <benjamin.wilson@databricks.com>
@BenWilson2 BenWilson2 enabled auto-merge November 13, 2025 15:43
@BenWilson2 BenWilson2 added this pull request to the merge queue Nov 13, 2025
Merged via the queue into mlflow:master with commit 64e138e Nov 13, 2025
46 checks passed
@BenWilson2 BenWilson2 deleted the fix-dl-docs branch November 13, 2025 16:26
Tian-Sky-Lan pushed a commit to Tian-Sky-Lan/mlflow that referenced this pull request Nov 24, 2025
Signed-off-by: Ben Wilson <benjamin.wilson@databricks.com>
Signed-off-by: Tian Lan <sky.blue266000@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/docs Documentation issues rn/documentation Mention under Documentation Changes in Changelogs. team-review Trigger a team review request v3.6.1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants