Skip to content

Remove deprecated diviner flavor#18808

Merged
harupy merged 3 commits intomasterfrom
copilot/remove-diviner-flavor
Nov 14, 2025
Merged

Remove deprecated diviner flavor#18808
harupy merged 3 commits intomasterfrom
copilot/remove-diviner-flavor

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Nov 12, 2025 •
edited
Loading

Related Issues/PRs

#xxx

What changes are proposed in this pull request?

Removes the diviner flavor, deprecated in MLflow 3.6.0.

Directories removed:

  • mlflow/diviner/ - Flavor implementation (618 lines)
  • tests/diviner/ - Test suite
  • examples/diviner/ - Example code
  • docs/api_reference/source/python_api/mlflow.diviner.rst - API docs

Files updated:

  • mlflow/__init__.py - Remove lazy loader
  • mlflow/models/__init__.py - Remove from docstring
  • mlflow/ml-package-versions.yml - Remove package config
  • mlflow/ml_package_versions.py - Remove version entry
  • mlflow/telemetry/constant.py - Remove from NON_GENAI_MODULES
  • requirements/extra-ml-requirements.txt - Remove dependency
  • docs/api_reference/api_inventory.txt - Remove diviner API references
  • docs/docs/classic-ml/model/index.mdx - Remove diviner flavor section
  • docs/docs/classic-ml/tutorials-and-examples/index.mdx - Remove diviner example reference
  • Test configuration files - Remove diviner test paths and fixtures

How is this PR tested?

  • Existing unit/integration tests
  • New unit/integration tests
  • Manual tests

Verified MLflow imports successfully without diviner in namespace. Confirmed other flavors (catboost, h2o, prophet, pmdarima) remain functional.

Does this PR require documentation update?

  • No. You can skip the rest of this section.
  • Yes. I've updated:
    • Examples
    • API references
    • Instructions

Release Notes

Is this a user-facing change?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release notes for MLflow users.

Removed the diviner flavor that was deprecated in MLflow 3.6.0. Users should migrate to alternative time series forecasting solutions.

What component(s), interfaces, languages, and integrations does this PR affect?

Components

  • area/tracking: Tracking Service, tracking client APIs, autologging
  • area/models: MLmodel format, model serialization/deserialization, flavors
  • area/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registry
  • area/scoring: MLflow Model server, model deployment tools, Spark UDFs
  • area/evaluation: MLflow model evaluation features, evaluation metrics, and evaluation workflows
  • area/gateway: MLflow AI Gateway client APIs, server, and third-party integrations
  • area/prompts: MLflow prompt engineering features, prompt templates, and prompt management
  • area/tracing: MLflow Tracing features, tracing APIs, and LLM tracing functionality
  • area/projects: MLproject format, project running backends
  • area/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev server
  • area/build: Build and test infrastructure for MLflow
  • area/docs: MLflow documentation pages

How should the PR be classified in the release notes? Choose one:

  • rn/none - No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" section
  • rn/breaking-change - The PR will be mentioned in the "Breaking Changes" section
  • rn/feature - A new user-facing feature worth mentioning in the release notes
  • rn/bug-fix - A user-facing bug fix worth mentioning in the release notes
  • rn/documentation - A user-facing documentation change worth mentioning in the release notes

Should this PR be included in the next patch release?

  • Yes (this PR will be cherry-picked and included in the next patch release)
  • No (this PR will be included in the next minor release)
Original prompt

Goal: Remove the diviner flavor from the MLflow codebase.
Rationale: In MLflow 3.6.0, we deprecated the diviner flavor, and in the upcoming release, we are removing it entirely.

Key files to remove/update

  • mlflow/diviner/

  • tests/diviner/

  • mlflow/ml-package-versions.yml (promptflaow entry)

  • examples, docs, etc.

  • Thouroughly search diviner in the codebase to ensure all references/files are removed.

  • We can igonre csv files and other non-code files that may reference diviner.

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

@harupy harupy marked this pull request as ready for review November 12, 2025 11:17
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 12, 2025

@Copilot Thank you for the contribution! Could you fix the following issue(s)?

⚠ Invalid PR template

This PR does not appear to have been filed using the MLflow PR template. Please copy the PR template from here and fill it out.

@harupy harupy added the team-review Trigger a team review request label Nov 12, 2025
@harupy
Remove diviner flavor from MLflow codebase
ded61aa 
- Removed mlflow/diviner/ directory
- Removed tests/diviner/ directory
- Removed examples/diviner/ directory
- Removed docs/api_reference/source/python_api/mlflow.diviner.rst file
- Updated mlflow/__init__.py to remove diviner lazy loader
- Updated mlflow/models/__init__.py to remove diviner from docstring
- Updated mlflow/ml-package-versions.yml to remove diviner entry
- Updated mlflow/ml_package_versions.py to remove diviner entry
- Updated mlflow/telemetry/constant.py to remove diviner from flavors list
- Updated mlflow/types/utils.py to remove diviner comment
- Updated requirements/extra-ml-requirements.txt to remove diviner requirement
- Updated tests/check_mlflow_lazily_imports_ml_packages.py
- Updated tests/conftest.py to remove diviner test path
- Updated tests/examples/test_examples.py to remove diviner example test
- Updated tests/pyfunc/docker/test_docker_flavors.py to remove diviner docker test
- Updated docs/api_reference/api_inventory.txt to remove diviner API references

Co-authored-by: harupy <17039389+harupy@users.noreply.github.com>
Copilot AI changed the title [WIP] Remove diviner flavor from MLflow codebase Remove deprecated diviner flavor Nov 12, 2025
@github-actions github-actions Bot added area/build Build and test infrastructure for MLflow area/docs Documentation issues area/models MLmodel format, model serialization/deserialization, flavors rn/breaking-change Mention under Breaking Changes in Changelogs. labels Nov 12, 2025
harupy
harupy reviewed Nov 12, 2025
View reviewed changes
Comment thread docs/api_reference/api_inventory.txt
@harupy
Remove diviner references from documentation
850b480 
- Removed diviner flavor section from docs/docs/classic-ml/model/index.mdx
- Removed diviner example reference from docs/docs/classic-ml/tutorials-and-examples/index.mdx

Co-authored-by: harupy <17039389+harupy@users.noreply.github.com>
Copilot AI requested a review from harupy November 12, 2025 11:54
BenWilson2
BenWilson2 approved these changes Nov 14, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@BenWilson2 BenWilson2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! さようなら Diviner

@harupy harupy merged commit 66be5b6 into master Nov 14, 2025
55 of 86 checks passed
@harupy harupy deleted the copilot/remove-diviner-flavor branch November 14, 2025 02:39
jackiehimel pushed a commit to jackiehimel/mlflow that referenced this pull request Nov 21, 2025
@harupy @jackiehimel
Remove deprecated diviner flavor (mlflow#18808)
f4349dc 
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: harupy <17039389+harupy@users.noreply.github.com>
Signed-off-by: Jackie Himel <jacqueline.himel@vanderbilt.edu>
mprahl pushed a commit to opendatahub-io/mlflow that referenced this pull request Nov 21, 2025
@harupy @mprahl
Remove deprecated diviner flavor (mlflow#18808)
d7de54d 
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: harupy <17039389+harupy@users.noreply.github.com>
Tian-Sky-Lan pushed a commit to Tian-Sky-Lan/mlflow that referenced this pull request Nov 24, 2025
@harupy @Tian-Sky-Lan
Remove deprecated diviner flavor (mlflow#18808)
9fcc591 
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: harupy <17039389+harupy@users.noreply.github.com>
Signed-off-by: Tian Lan <sky.blue266000@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@B-Step62 B-Step62 Awaiting requested review from B-Step62

@daniellok-db daniellok-db Awaiting requested review from daniellok-db

@kevin-lyn kevin-lyn Awaiting requested review from kevin-lyn

@serena-ruan serena-ruan Awaiting requested review from serena-ruan

@TomeHirata TomeHirata Awaiting requested review from TomeHirata

@WeichenXu123 WeichenXu123 Awaiting requested review from WeichenXu123

@xq-yin xq-yin Awaiting requested review from xq-yin

@harupy harupy Awaiting requested review from harupy

1 more reviewer

@BenWilson2 BenWilson2 BenWilson2 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@harupy harupy

Copilot code review Copilot

Labels

area/build Build and test infrastructure for MLflow area/docs Documentation issues area/models MLmodel format, model serialization/deserialization, flavors rn/breaking-change Mention under Breaking Changes in Changelogs. team-review Trigger a team review request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@harupy @BenWilson2