Skip to content

Fix Semantic Kernel tracing cross version test#18787

Merged
B-Step62 merged 4 commits intomlflow:masterfrom
B-Step62:fix-sk-dev
Nov 14, 2025
Merged

Fix Semantic Kernel tracing cross version test#18787
B-Step62 merged 4 commits intomlflow:masterfrom
B-Step62:fix-sk-dev

Conversation

@B-Step62
Copy link
Collaborator

@B-Step62 B-Step62 commented Nov 11, 2025

🛠 DevTools 🛠

Open in GitHub Codespaces

Install mlflow from this PR

# mlflow
pip install git+https://github.com/mlflow/mlflow.git@refs/pull/18787/merge
# mlflow-skinny
pip install git+https://github.com/mlflow/mlflow.git@refs/pull/18787/merge#subdirectory=libs/skinny

For Databricks, use the following command:

%sh curl -LsSf https://raw.githubusercontent.com/mlflow/mlflow/HEAD/dev/install-skinny.sh | sh -s pull/18787/merge

Related Issues/PRs

https://github.com/mlflow/dev/actions/runs/19266812224/job/55084666816#step:13:63

What changes are proposed in this pull request?

The CHAT_STREAMING_COMPLETION_OPERATION and TEXT_STREAMING_COMPLETION_OPERATION constants were removed and consolidated into non-stream ones: microsoft/semantic-kernel@b2cceb5

This caused import error in cvt.

How is this PR tested?

  • Existing unit/integration tests
  • New unit/integration tests
  • Manual tests

Does this PR require documentation update?

  • No. You can skip the rest of this section.
  • Yes. I've updated:
    • Examples
    • API references
    • Instructions

Release Notes

Is this a user-facing change?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release notes for MLflow users.

What component(s), interfaces, languages, and integrations does this PR affect?

Components

  • area/tracking: Tracking Service, tracking client APIs, autologging
  • area/models: MLmodel format, model serialization/deserialization, flavors
  • area/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registry
  • area/scoring: MLflow Model server, model deployment tools, Spark UDFs
  • area/evaluation: MLflow model evaluation features, evaluation metrics, and evaluation workflows
  • area/gateway: MLflow AI Gateway client APIs, server, and third-party integrations
  • area/prompts: MLflow prompt engineering features, prompt templates, and prompt management
  • area/tracing: MLflow Tracing features, tracing APIs, and LLM tracing functionality
  • area/projects: MLproject format, project running backends
  • area/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev server
  • area/build: Build and test infrastructure for MLflow
  • area/docs: MLflow documentation pages

How should the PR be classified in the release notes? Choose one:

  • rn/none - No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" section
  • rn/breaking-change - The PR will be mentioned in the "Breaking Changes" section
  • rn/feature - A new user-facing feature worth mentioning in the release notes
  • rn/bug-fix - A user-facing bug fix worth mentioning in the release notes
  • rn/documentation - A user-facing documentation change worth mentioning in the release notes

Should this PR be included in the next patch release?

Yes should be selected for bug fixes, documentation updates, and other small changes. No should be selected for new features and larger changes. If you're unsure about the release classification of this PR, leave this unchecked to let the maintainers decide.

What is a minor/patch release?
  • Minor release: a release that increments the second part of the version number (e.g., 1.2.0 -> 1.3.0).
    Bug fixes, doc updates and new features usually go into minor releases.
  • Patch release: a release that increments the third part of the version number (e.g., 1.2.0 -> 1.2.1).
    Bug fixes and doc updates usually go into patch releases.
  • Yes (this PR will be cherry-picked and included in the next patch release)
  • No (this PR will be included in the next minor release)

Signed-off-by: B-Step62 <yuki.watanabe@databricks.com>
@B-Step62 B-Step62 added the enable-dev-tests Enables cross-version tests for dev versions label Nov 11, 2025
@github-actions github-actions bot added v3.6.1 area/tracing MLflow Tracing and its integrations rn/none List under Small Changes in Changelogs. labels Nov 11, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 11, 2025

Documentation preview for f707999 is available at:

More info
  • Ignore this comment if this PR does not change the documentation.
  • The preview is updated when a new commit is pushed to this PR.
  • This comment was created by this workflow run.
  • The documentation was built by this workflow run.

Signed-off-by: B-Step62 <yuki.watanabe@databricks.com>
Signed-off-by: B-Step62 <yuki.watanabe@databricks.com>
"invoke_agent": SpanType.AGENT,
}

# NB: Streaming operation names are removed in Semantic Kernel
Copy link
Member

@harupy harupy Nov 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# NB: Streaming operation names are removed in Semantic Kernel
# NB: Streaming operation names were removed in Semantic Kernel x.y.z

Let's use were here. are makes it unclear whether they still exist.

Copy link
Member

@harupy harupy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once the comment is addressed!

Signed-off-by: B-Step62 <yuki.watanabe@databricks.com>
@B-Step62 B-Step62 enabled auto-merge November 14, 2025 13:33
@B-Step62 B-Step62 added this pull request to the merge queue Nov 14, 2025
Merged via the queue into mlflow:master with commit da4a411 Nov 14, 2025
50 checks passed
@B-Step62 B-Step62 deleted the fix-sk-dev branch November 14, 2025 14:12
jackiehimel pushed a commit to jackiehimel/mlflow that referenced this pull request Nov 21, 2025
Signed-off-by: B-Step62 <yuki.watanabe@databricks.com>
Signed-off-by: Jackie Himel <jacqueline.himel@vanderbilt.edu>
mprahl pushed a commit to opendatahub-io/mlflow that referenced this pull request Nov 21, 2025
Signed-off-by: B-Step62 <yuki.watanabe@databricks.com>
Tian-Sky-Lan pushed a commit to Tian-Sky-Lan/mlflow that referenced this pull request Nov 24, 2025
Signed-off-by: B-Step62 <yuki.watanabe@databricks.com>
Signed-off-by: Tian Lan <sky.blue266000@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/tracing MLflow Tracing and its integrations enable-dev-tests Enables cross-version tests for dev versions rn/none List under Small Changes in Changelogs. team-review Trigger a team review request v3.6.1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants