Skip to content

Fix attributes encoding issue#18780

Merged
serena-ruan merged 4 commits intomlflow:masterfrom
serena-ruan:fix_18767
Nov 19, 2025
Merged

Fix attributes encoding issue#18780
serena-ruan merged 4 commits intomlflow:masterfrom
serena-ruan:fix_18767

Conversation

@serena-ruan
Copy link
Collaborator

@serena-ruan serena-ruan commented Nov 11, 2025

🛠 DevTools 🛠

Open in GitHub Codespaces

Install mlflow from this PR

# mlflow
pip install git+https://github.com/mlflow/mlflow.git@refs/pull/18780/merge
# mlflow-skinny
pip install git+https://github.com/mlflow/mlflow.git@refs/pull/18780/merge#subdirectory=libs/skinny

For Databricks, use the following command:

%sh curl -LsSf https://raw.githubusercontent.com/mlflow/mlflow/HEAD/dev/install-skinny.sh | sh -s pull/18780/merge

Related Issues/PRs

Resolve #18767

What changes are proposed in this pull request?

Sanitize the attributes before saving in sql store.

How is this PR tested?

  • Existing unit/integration tests
  • New unit/integration tests
  • Manual tests

Does this PR require documentation update?

  • No. You can skip the rest of this section.
  • Yes. I've updated:
    • Examples
    • API references
    • Instructions

Release Notes

Is this a user-facing change?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release notes for MLflow users.

What component(s), interfaces, languages, and integrations does this PR affect?

Components

  • area/tracking: Tracking Service, tracking client APIs, autologging
  • area/models: MLmodel format, model serialization/deserialization, flavors
  • area/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registry
  • area/scoring: MLflow Model server, model deployment tools, Spark UDFs
  • area/evaluation: MLflow model evaluation features, evaluation metrics, and evaluation workflows
  • area/gateway: MLflow AI Gateway client APIs, server, and third-party integrations
  • area/prompts: MLflow prompt engineering features, prompt templates, and prompt management
  • area/tracing: MLflow Tracing features, tracing APIs, and LLM tracing functionality
  • area/projects: MLproject format, project running backends
  • area/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev server
  • area/build: Build and test infrastructure for MLflow
  • area/docs: MLflow documentation pages

How should the PR be classified in the release notes? Choose one:

  • rn/none - No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" section
  • rn/breaking-change - The PR will be mentioned in the "Breaking Changes" section
  • rn/feature - A new user-facing feature worth mentioning in the release notes
  • rn/bug-fix - A user-facing bug fix worth mentioning in the release notes
  • rn/documentation - A user-facing documentation change worth mentioning in the release notes

Should this PR be included in the next patch release?

Yes should be selected for bug fixes, documentation updates, and other small changes. No should be selected for new features and larger changes. If you're unsure about the release classification of this PR, leave this unchecked to let the maintainers decide.

What is a minor/patch release?
  • Minor release: a release that increments the second part of the version number (e.g., 1.2.0 -> 1.3.0).
    Bug fixes, doc updates and new features usually go into minor releases.
  • Patch release: a release that increments the third part of the version number (e.g., 1.2.0 -> 1.2.1).
    Bug fixes and doc updates usually go into patch releases.
  • Yes (this PR will be cherry-picked and included in the next patch release)
  • No (this PR will be included in the next minor release)

Signed-off-by: Serena Ruan <serena.rxy@gmail.com>
@github-actions github-actions bot added the rn/none List under Small Changes in Changelogs. label Nov 11, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 11, 2025

Documentation preview for 976df79 is available at:

More info
  • Ignore this comment if this PR does not change the documentation.
  • The preview is updated when a new commit is pushed to this PR.
  • This comment was created by this workflow run.
  • The documentation was built by this workflow run.

Signed-off-by: Serena Ruan <serena.rxy@gmail.com>
Signed-off-by: Serena Ruan <serena.rxy@gmail.com>
@serena-ruan
Copy link
Collaborator Author

/cvt langgraph,dspy

@github-actions
Copy link
Contributor

Cross-version test run started: https://github.com/mlflow/mlflow/actions/runs/19290585838

@serena-ruan serena-ruan requested a review from B-Step62 November 12, 2025 09:14
Copy link
Collaborator

@B-Step62 B-Step62 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pending our homework to think about more efficient apporoach.

Signed-off-by: Serena Ruan <serena.rxy@gmail.com>
@serena-ruan
Copy link
Collaborator Author

Failing test is not related to this PR, it fails on https://github.com/mlflow/mlflow/actions/runs/19491945942/job/55785789954?pr=18778 as well

@serena-ruan serena-ruan merged commit 2694e73 into mlflow:master Nov 19, 2025
46 of 48 checks passed
mprahl pushed a commit to opendatahub-io/mlflow that referenced this pull request Nov 21, 2025
Signed-off-by: Serena Ruan <serena.rxy@gmail.com>
Tian-Sky-Lan pushed a commit to Tian-Sky-Lan/mlflow that referenced this pull request Nov 24, 2025
Signed-off-by: Serena Ruan <serena.rxy@gmail.com>
Signed-off-by: Tian Lan <sky.blue266000@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rn/none List under Small Changes in Changelogs.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] OTLP Ingestion Double-Encodes JSON String Attributes

2 participants