Replace yarn --cwd with (cd && yarn) pattern in dev/run-dev-server.sh#18652
Merged
Replace yarn --cwd with (cd && yarn) pattern in dev/run-dev-server.sh#18652
yarn --cwd with (cd && yarn) pattern in dev/run-dev-server.sh#18652Conversation
Contributor
|
@Copilot Thank you for the contribution! Could you fix the following issue(s)? ⚠ Invalid PR templateThis PR does not appear to have been filed using the MLflow PR template. Please copy the PR template from here and fill it out. |
Replace `yarn --cwd mlflow/server/js start` with `(cd mlflow/server/js && yarn start)` to align with the pattern used in CLAUDE.md documentation and ensure proper working directory context. This change makes the script consistent with other yarn commands documented in the repository. Signed-off-by: GitHub Copilot <noreply@github.com> Co-authored-by: harupy <17039389+harupy@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update run-dev-server.sh to set proper working directory
Replace Nov 4, 2025
yarn --cwd with (cd && yarn) pattern in dev/run-dev-server.sh
harupy
approved these changes
Nov 4, 2025
Copilot AI
added a commit
that referenced
this pull request
Nov 4, 2025
…r.sh (#18652) Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: harupy <17039389+harupy@users.noreply.github.com>
Copilot AI
added a commit
that referenced
this pull request
Nov 4, 2025
- Remove obsolete 'yarn.*--cwd.*mlflow/server/js.*start' pattern - Update comment to reflect new (cd && yarn) command pattern - Pattern 'mlflow/server/js.*yarn.*start' still matches the spawned node process - Rebased on master to include PR #18652 changes Co-authored-by: harupy <17039389+harupy@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aligns dev server script with repository conventions by using the standard
(cd ... && yarn ...)pattern instead ofyarn --cwd.Changes
yarn --cwd mlflow/server/js startwith(cd mlflow/server/js && yarn start)on line 72This matches the pattern used throughout CLAUDE.md and provides consistent working directory context across all yarn invocations in the repository.
Follow-up to #18553.
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.