Skip to content

[Eval #1] Fix uniquness handling of trace linking#18414

Merged
B-Step62 merged 1 commit intomlflow:masterfrom
B-Step62:stack/migrate-eval-1
Oct 21, 2025
Merged

[Eval #1] Fix uniquness handling of trace linking#18414
B-Step62 merged 1 commit intomlflow:masterfrom
B-Step62:stack/migrate-eval-1

Conversation

@B-Step62
Copy link
Collaborator

@B-Step62 B-Step62 commented Oct 20, 2025

🥞 Stacked PR

Use this link to review incremental changes.


What changes are proposed in this pull request?

A small prep work for migrating (unifying) DBX eval harness into OSS one. The LinkTracesToRun implementation in SQL store has an issue that it doesn't check the existing rows, therefore when we call the API with a pair of trace and run that are already linked, the API raises an SQL uniqueness constraint error. It is not desirable that we need to check the uniqueness at client side so this should be idempotent.

How is this PR tested?

  • Existing unit/integration tests
  • New unit/integration tests
  • Manual tests

Does this PR require documentation update?

  • No. You can skip the rest of this section.
  • Yes. I've updated:
    • Examples
    • API references
    • Instructions

Release Notes

Is this a user-facing change?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release notes for MLflow users.

What component(s), interfaces, languages, and integrations does this PR affect?

Components

  • area/tracking: Tracking Service, tracking client APIs, autologging
  • area/models: MLmodel format, model serialization/deserialization, flavors
  • area/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registry
  • area/scoring: MLflow Model server, model deployment tools, Spark UDFs
  • area/evaluation: MLflow model evaluation features, evaluation metrics, and evaluation workflows
  • area/gateway: MLflow AI Gateway client APIs, server, and third-party integrations
  • area/prompts: MLflow prompt engineering features, prompt templates, and prompt management
  • area/tracing: MLflow Tracing features, tracing APIs, and LLM tracing functionality
  • area/projects: MLproject format, project running backends
  • area/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev server
  • area/build: Build and test infrastructure for MLflow
  • area/docs: MLflow documentation pages

How should the PR be classified in the release notes? Choose one:

  • rn/none - No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" section
  • rn/breaking-change - The PR will be mentioned in the "Breaking Changes" section
  • rn/feature - A new user-facing feature worth mentioning in the release notes
  • rn/bug-fix - A user-facing bug fix worth mentioning in the release notes
  • rn/documentation - A user-facing documentation change worth mentioning in the release notes

Should this PR be included in the next patch release?

Yes should be selected for bug fixes, documentation updates, and other small changes. No should be selected for new features and larger changes. If you're unsure about the release classification of this PR, leave this unchecked to let the maintainers decide.

What is a minor/patch release?
  • Minor release: a release that increments the second part of the version number (e.g., 1.2.0 -> 1.3.0).
    Bug fixes, doc updates and new features usually go into minor releases.
  • Patch release: a release that increments the third part of the version number (e.g., 1.2.0 -> 1.2.1).
    Bug fixes and doc updates usually go into patch releases.
  • Yes (this PR will be cherry-picked and included in the next patch release)
  • No (this PR will be included in the next minor release)

Signed-off-by: B-Step62 <yuki.watanabe@databricks.com>
@github-actions
Copy link
Contributor

Documentation preview for e60f399 is available at:

More info
  • Ignore this comment if this PR does not change the documentation.
  • The preview is updated when a new commit is pushed to this PR.
  • This comment was created by this workflow run.
  • The documentation was built by this workflow run.

@B-Step62 B-Step62 added the team-review Trigger a team review request label Oct 20, 2025
@B-Step62 B-Step62 changed the title Fix uniquness handling of trace linking [Eval #1[ Fix uniquness handling of trace linking Oct 20, 2025
@B-Step62 B-Step62 changed the title [Eval #1[ Fix uniquness handling of trace linking [Eval #1] Fix uniquness handling of trace linking Oct 20, 2025
Copy link
Collaborator

@WeichenXu123 WeichenXu123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@B-Step62 B-Step62 added this pull request to the merge queue Oct 21, 2025
Merged via the queue into mlflow:master with commit edcbfa8 Oct 21, 2025
77 of 88 checks passed
@B-Step62 B-Step62 deleted the stack/migrate-eval-1 branch October 21, 2025 23:06
juntai-zheng pushed a commit to juntai-zheng/mlflow that referenced this pull request Oct 28, 2025
Signed-off-by: B-Step62 <yuki.watanabe@databricks.com>
Signed-off-by: juntai-zheng <juntai.zheng@gmail.com>
NJAHNAVI2907 pushed a commit to NJAHNAVI2907/mlflow that referenced this pull request Jan 22, 2026
Signed-off-by: B-Step62 <yuki.watanabe@databricks.com>
Signed-off-by: NJAHNAVI2907 <jahnavinelavelli29@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/evaluation MLflow Evaluation rn/none List under Small Changes in Changelogs. team-review Trigger a team review request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants