Fix mlflow gc to remove model artifacts by joelrobin18 · Pull Request #17282 · mlflow/mlflow

joelrobin18 · 2025-08-19T04:29:31Z

🛠 DevTools 🛠

Install mlflow from this PR

# mlflow
pip install git+https://github.com/mlflow/mlflow.git@refs/pull/17282/merge
# mlflow-skinny
pip install git+https://github.com/mlflow/mlflow.git@refs/pull/17282/merge#subdirectory=libs/skinny

For Databricks, use the following command:

%sh curl -LsSf https://raw.githubusercontent.com/mlflow/mlflow/HEAD/dev/install-skinny.sh | sh -s pull/17282/merge

Related Issues/PRs

Fix #17240

What changes are proposed in this pull request?

Fix mlflow gc to remove model artifacts

How is this PR tested?

Existing unit/integration tests
New unit/integration tests
Manual tests

Does this PR require documentation update?

Release Notes

Is this a user-facing change?

No. You can skip the rest of this section.
Yes. Give a description of this change to be included in the release notes for MLflow users.

What component(s), interfaces, languages, and integrations does this PR affect?

Components

How should the PR be classified in the release notes? Choose one:

rn/none - No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" section
rn/breaking-change - The PR will be mentioned in the "Breaking Changes" section
rn/feature - A new user-facing feature worth mentioning in the release notes
rn/bug-fix - A user-facing bug fix worth mentioning in the release notes
rn/documentation - A user-facing documentation change worth mentioning in the release notes

Should this PR be included in the next patch release?

Yes should be selected for bug fixes, documentation updates, and other small changes. No should be selected for new features and larger changes. If you're unsure about the release classification of this PR, leave this unchecked to let the maintainers decide.

What is a minor/patch release?

Minor release: a release that increments the second part of the version number (e.g., 1.2.0 -> 1.3.0).
Bug fixes, doc updates and new features usually go into minor releases.
Patch release: a release that increments the third part of the version number (e.g., 1.2.0 -> 1.2.1).
Bug fixes and doc updates usually go into patch releases.

Yes (this PR will be cherry-picked and included in the next patch release)
No (this PR will be included in the next minor release)

Signed-off-by: joelrobin18 <joelrobin1818@gmail.com>

joelrobin18 · 2025-08-19T04:33:38Z

@B-Step62 Could you please TAL this PR? Thanks!

Signed-off-by: joelrobin18 <joelrobin1818@gmail.com>

mlflow/store/tracking/file_store.py

joelrobin18 · 2025-09-12T12:04:27Z

@TomeHirata @harupy Could you please review this PR? Thanks!

Copilot

Pull Request Overview

This PR implements support for garbage collection of logged model artifacts in MLflow, addressing issue #17240. The change extends the mlflow gc command to permanently delete logged models that are in the deleted lifecycle stage, similar to how it handles runs and experiments.

Adds logged model garbage collection functionality to the mlflow gc CLI command
Implements _hard_delete_logged_model and _get_deleted_logged_models methods in both FileStore and SqlAlchemyStore
Adds comprehensive test coverage for the new logged model garbage collection features

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
mlflow/cli/init.py	Extends the gc command to support logged model deletion with new CLI options and deletion logic
mlflow/store/tracking/file_store.py	Implements logged model hard deletion and retrieval methods for file-based storage
mlflow/store/tracking/sqlalchemy_store.py	Implements logged model hard deletion and retrieval methods for SQL-based storage
tests/test_cli.py	Adds comprehensive test coverage for logged model garbage collection functionality
tests/store/tracking/test_file_store.py	Adds unit tests for FileStore logged model deletion methods
tests/store/tracking/test_sqlalchemy_store.py	Adds unit tests for SqlAlchemyStore logged model deletion methods

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

TomeHirata · 2025-09-17T06:05:11Z

mlflow/cli/__init__.py

-                error_code=INVALID_PARAMETER_VALUE,
-            )
-        artifact_repo = get_artifact_repository(run.info.artifact_uri)
+    def _delete_with_artifacts(artifact_uri, delete_fn, entity_desc):


We probably don't need to combine artifact deletion, entity deletion, and description display. Can we simply define a function for artifact deletion only?

mlflow/store/tracking/file_store.py

Signed-off-by: joelrobin18 <joelrobin1818@gmail.com>

github-actions · 2025-09-29T00:14:04Z

Documentation preview for 2165452 is available at:

https://pr-17282--mlflow-docs-preview.netlify.app/docs/latest/

More info

Ignore this comment if this PR does not change the documentation.
The preview is updated when a new commit is pushed to this PR.
This comment was created by this workflow run.
The documentation was built by this workflow run.

B-Step62 · 2025-09-29T00:17:09Z

mlflow/store/tracking/file_store.py

            The fetched model.
        """
-        return LoggedModel.from_dictionary(self._get_model_dict(model_id))
+        if not allow_deleted:


@harupy @serena-ruan This allow_deleted here is added because get_logged_model raises an exception when the model is deleted. However, it is a bit interesting because other entities like runs/experiments/traces do not have this behavior, namely, does not raise for deleted ones. Do you remember is there any particular reason we have inconsistent behavior for logged models? Same for SQL store.

B-Step62

LGTM

Signed-off-by: joelrobin18 <joelrobin1818@gmail.com>

Signed-off-by: joelrobin18 <joelrobin1818@gmail.com> Co-authored-by: Yuki Watanabe <31463517+B-Step62@users.noreply.github.com> Signed-off-by: Tian Lan <sky.blue266000@gmail.com>

Fix mlflow gc to remove model artifacts

dce8af1

Signed-off-by: joelrobin18 <joelrobin1818@gmail.com>

github-actions bot added v3.3.0 area/build Build and test infrastructure for MLflow rn/bug-fix Mention under Bug Fixes in Changelogs. labels Aug 19, 2025

Updates

7364d61

Signed-off-by: joelrobin18 <joelrobin1818@gmail.com>

joelrobin18 added 4 commits August 19, 2025 10:48

Fix cli + test case

0a626ec

Signed-off-by: joelrobin18 <joelrobin1818@gmail.com>

Fix cli + test case

90e5a9b

Signed-off-by: joelrobin18 <joelrobin1818@gmail.com>

Fix cli

c68e9ca

Signed-off-by: joelrobin18 <joelrobin1818@gmail.com>

Test cases

095c844

Signed-off-by: joelrobin18 <joelrobin1818@gmail.com>

B-Step62 removed the v3.3.0 label Aug 19, 2025

Logic Fix

1195bfe

Signed-off-by: joelrobin18 <joelrobin1818@gmail.com>

github-actions bot added the v3.3.3 label Sep 12, 2025

joelrobin18 added 2 commits September 12, 2025 17:14

Logic Fix

e94b8e6

Signed-off-by: joelrobin18 <joelrobin1818@gmail.com>

Merge branch 'master' into fix-17240

5d493da

joelrobin18 commented Sep 12, 2025

View reviewed changes

mlflow/store/tracking/file_store.py Outdated Show resolved Hide resolved

TomeHirata requested a review from Copilot September 17, 2025 04:56

Copilot AI reviewed Sep 17, 2025

View reviewed changes

TomeHirata reviewed Sep 17, 2025

View reviewed changes

mlflow/store/tracking/file_store.py Outdated Show resolved Hide resolved

joelrobin18 added 2 commits September 26, 2025 15:31

Merge branch 'master' into fix-17240

468b047

Updates

95ce8a7

Signed-off-by: joelrobin18 <joelrobin1818@gmail.com>

joelrobin18 force-pushed the fix-17240 branch from 0edf22a to 95ce8a7 Compare September 26, 2025 12:37

Updates

bd2a0a0

Signed-off-by: joelrobin18 <joelrobin1818@gmail.com>

B-Step62 reviewed Sep 29, 2025

View reviewed changes

B-Step62 self-assigned this Nov 19, 2025

B-Step62 approved these changes Nov 19, 2025

View reviewed changes

Merge branch 'master' into fix-17240

8c6de0d

joelrobin18 mentioned this pull request Nov 21, 2025

[BUG] mlflow gc not deleting model artifacts from object storage #17240

Closed

11 tasks

CI fix

2165452

Signed-off-by: joelrobin18 <joelrobin1818@gmail.com>

joelrobin18 force-pushed the fix-17240 branch from 0f9a9df to 2165452 Compare November 22, 2025 06:03

B-Step62 added this pull request to the merge queue Nov 24, 2025

Merged via the queue into mlflow:master with commit 6e1b7a6 Nov 24, 2025
46 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix mlflow gc to remove model artifacts#17282

Fix mlflow gc to remove model artifacts#17282
B-Step62 merged 14 commits intomlflow:masterfrom
joelrobin18:fix-17240

joelrobin18 commented Aug 19, 2025 •

edited by github-actions bot

Loading

Uh oh!

joelrobin18 commented Aug 19, 2025

Uh oh!

Uh oh!

joelrobin18 commented Sep 12, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

TomeHirata Sep 17, 2025 •

edited

Loading

Uh oh!

Uh oh!

github-actions bot commented Sep 29, 2025 •

edited

Loading

Uh oh!

B-Step62 Sep 29, 2025 •

edited

Loading

Uh oh!

B-Step62 left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

joelrobin18 commented Aug 19, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Install mlflow from this PR

Related Issues/PRs

What changes are proposed in this pull request?

How is this PR tested?

Does this PR require documentation update?

Release Notes

Is this a user-facing change?

What component(s), interfaces, languages, and integrations does this PR affect?

How should the PR be classified in the release notes? Choose one:

Should this PR be included in the next patch release?

Uh oh!

joelrobin18 commented Aug 19, 2025

Uh oh!

Uh oh!

joelrobin18 commented Sep 12, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

TomeHirata Sep 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Sep 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

B-Step62 Sep 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

B-Step62 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

joelrobin18 commented Aug 19, 2025 •

edited by github-actions bot

Loading

TomeHirata Sep 17, 2025 •

edited

Loading

github-actions bot commented Sep 29, 2025 •

edited

Loading

B-Step62 Sep 29, 2025 •

edited

Loading