Skip to content

Fix single artifact downloading through HttpArtifactRepository#12955

Merged
B-Step62 merged 5 commits intomlflow:masterfrom
Koenkk:fix/artifact-downloading
Feb 28, 2026
Merged

Fix single artifact downloading through HttpArtifactRepository#12955
B-Step62 merged 5 commits intomlflow:masterfrom
Koenkk:fix/artifact-downloading

Conversation

@Koenkk
Copy link
Contributor

@Koenkk Koenkk commented Aug 15, 2024

🛠 DevTools 🛠

Open in GitHub Codespaces

Install mlflow from this PR

pip install git+https://github.com/mlflow/mlflow.git@refs/pull/12954/merge

Checkout with GitHub CLI

gh pr checkout 12954

Related Issues/PRs

  • None

What changes are proposed in this pull request?

The HttpArtifactRepository returns results on a list_artifacts() when listing a single artifact. This is not correct and instead it should return an empty list like the AzureBlobArtifactRepository does. This results in an error when downloading a single artifact via the HttpArtifactRepository.

This PR fixes the HttpArtifactRepository.list_artifacts() to return an empty list when listing a single artifact.

How is this PR tested?

  • Existing unit/integration tests
  • New unit/integration tests
  • Manual tests

Does this PR require documentation update?

  • No. You can skip the rest of this section.
  • Yes. I've updated:
    • Examples
    • API references
    • Instructions

Release Notes

Is this a user-facing change?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release notes for MLflow users.

Fix client.download_artifacts() failing when trying to download a single artifact via HttpArtifactRepository.

What component(s), interfaces, languages, and integrations does this PR affect?

Components

  • area/artifacts: Artifact stores and artifact logging
  • area/build: Build and test infrastructure for MLflow
  • area/deployments: MLflow Deployments client APIs, server, and third-party Deployments integrations
  • area/docs: MLflow documentation pages
  • area/examples: Example code
  • area/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registry
  • area/models: MLmodel format, model serialization/deserialization, flavors
  • area/recipes: Recipes, Recipe APIs, Recipe configs, Recipe Templates
  • area/projects: MLproject format, project running backends
  • area/scoring: MLflow Model server, model deployment tools, Spark UDFs
  • area/server-infra: MLflow Tracking server backend
  • area/tracking: Tracking Service, tracking client APIs, autologging

Interface

  • area/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev server
  • area/docker: Docker use across MLflow's components, such as MLflow Projects and MLflow Models
  • area/sqlalchemy: Use of SQLAlchemy in the Tracking Service or Model Registry
  • area/windows: Windows support

Language

  • language/r: R APIs and clients
  • language/java: Java APIs and clients
  • language/new: Proposals for new client languages

Integrations

  • integrations/azure: Azure and Azure ML integrations
  • integrations/sagemaker: SageMaker integrations
  • integrations/databricks: Databricks integrations

How should the PR be classified in the release notes? Choose one:

  • rn/none - No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" section
  • rn/breaking-change - The PR will be mentioned in the "Breaking Changes" section
  • rn/feature - A new user-facing feature worth mentioning in the release notes
  • rn/bug-fix - A user-facing bug fix worth mentioning in the release notes
  • rn/documentation - A user-facing documentation change worth mentioning in the release notes

Should this PR be included in the next patch release?

Yes should be selected for bug fixes, documentation updates, and other small changes. No should be selected for new features and larger changes. If you're unsure about the release classification of this PR, leave this unchecked to let the maintainers decide.

What is a minor/patch release?
  • Minor release: a release that increments the second part of the version number (e.g., 1.2.0 -> 1.3.0).
    Bug fixes, doc updates and new features usually go into minor releases.
  • Patch release: a release that increments the third part of the version number (e.g., 1.2.0 -> 1.2.1).
    Bug fixes and doc updates usually go into patch releases.
  • Yes (this PR will be cherry-picked and included in the next patch release)
  • No (this PR will be included in the next minor release)

Signed-off-by: Koen Kanters <koenkanters94@gmail.com>
@github-actions
Copy link
Contributor

github-actions bot commented Aug 15, 2024

Documentation preview for fc3d1ea is available at:

More info
  • Ignore this comment if this PR does not change the documentation.
  • The preview is updated when a new commit is pushed to this PR.
  • This comment was created by this workflow run.
  • The documentation was built by this workflow run.

@github-actions github-actions bot added area/artifacts Artifact stores and artifact logging rn/bug-fix Mention under Bug Fixes in Changelogs. labels Aug 15, 2024
@B-Step62
Copy link
Collaborator

B-Step62 commented Aug 16, 2024

@Koenkk Thank you for raising the issue and proactively submit the fix!

The change looks good to me🙂 Sorry I overlooked one corner case., added a comment.

Signed-off-by: Koen Kanters <koenkanters94@gmail.com>
@Koenkk Koenkk changed the title Fix single artifact downloading Fix single artifact downloading through HttpArtifactRepository Aug 23, 2024
@Koenkk Koenkk requested a review from B-Step62 August 23, 2024 14:22
…ading

Signed-off-by: Koen Kanters <koenkanters94@gmail.com>
@Koenkk
Copy link
Contributor Author

Koenkk commented Feb 9, 2025

@B-Step62 can I do anything to move this forward?

Copilot AI review requested due to automatic review settings February 27, 2026 10:34
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review is ineligible. To be eligible to request a review, you need a paid Copilot license, or your organization must enable Copilot code review.

@B-Step62 B-Step62 added this pull request to the merge queue Feb 28, 2026
Merged via the queue into mlflow:master with commit 64deb16 Feb 28, 2026
87 of 94 checks passed
daniellok-db pushed a commit to daniellok-db/mlflow that referenced this pull request Mar 5, 2026
…low#12955)

Signed-off-by: Koen Kanters <koenkanters94@gmail.com>
Co-authored-by: Yuki Watanabe <31463517+B-Step62@users.noreply.github.com>
daniellok-db pushed a commit to daniellok-db/mlflow that referenced this pull request Mar 5, 2026
…low#12955)

Signed-off-by: Koen Kanters <koenkanters94@gmail.com>
Co-authored-by: Yuki Watanabe <31463517+B-Step62@users.noreply.github.com>
daniellok-db pushed a commit that referenced this pull request Mar 5, 2026
)

Signed-off-by: Koen Kanters <koenkanters94@gmail.com>
Co-authored-by: Yuki Watanabe <31463517+B-Step62@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/artifacts Artifact stores and artifact logging rn/bug-fix Mention under Bug Fixes in Changelogs. size/M v3.10.1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants