Merged
Conversation
davidkoski
commented
Nov 5, 2025
| brew install swift-format | ||
| pre-commit run --all || (echo "Style checks failed, please install pre-commit and run pre-commit run --all and push the change"; echo ""; git --no-pager diff; exit 1) | ||
| - run: | ||
| name: Run Tests (Xcode, macOS) |
Collaborator
Author
There was a problem hiding this comment.
These tests are part of the library, not the example apps
davidkoski
commented
Nov 5, 2025
awni
reviewed
Nov 11, 2025
| - MLXLMCommon: Common language model utilities | ||
| - [MLX](https://github.com/ml-explore/mlx-swift): Core machine learning operations | ||
| - [MLXLMCommon](https://github.com/ml-explore/mlx-swift-lm): Common language model utilities | ||
| - MLXLLM: Large language model support |
Member
There was a problem hiding this comment.
Maybe add links for these as well so it's clear where they come from?
awni
reviewed
Nov 11, 2025
awni
reviewed
Nov 11, 2025
awni
reviewed
Nov 11, 2025
awni
approved these changes
Nov 11, 2025
Member
awni
left a comment
There was a problem hiding this comment.
Minor comments, o/w looks great!
Co-authored-by: Awni Hannun <awni.hannun@gmail.com>
davidkoski
added a commit
that referenced
this pull request
Nov 11, 2025
davidkoski
added a commit
that referenced
this pull request
Nov 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: this won't build yet until the other repository is live. This is set up using a local repository.Switched