Skip to content

Fix document symbol links#93

Merged
davidkoski merged 1 commit intoml-explore:mainfrom
kemchenj:doc_symbol_links
Apr 10, 2025
Merged

Fix document symbol links#93
davidkoski merged 1 commit intoml-explore:mainfrom
kemchenj:doc_symbol_links

Conversation

@kemchenj
Copy link
Contributor

There is a bug around swift-docc that could not generate symbol links for - -= / /=.

And this was fixed in Swift 5.10 based on swiftlang/swift-docc#808. So this PR adds symbol links for these operators.

@kemchenj
Copy link
Contributor Author

And I tried to run Build Documentation on Xcode 15.3, it works as expected:

Screenshot 2024-05-26 at 21 05 53

@@ -1,4 +1,4 @@
// swift-tools-version: 5.9
// swift-tools-version: 5.10
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only concern is this bump -- it moves the requirement forward from 2023 -> 2024 for Xcode & swift versions.

I don't think we ave a good way to judge what people are using, so perhaps we just take this and can consider reverting if it causes trouble.

Copy link
Collaborator

@davidkoski davidkoski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update!

@davidkoski davidkoski merged commit 2f41704 into ml-explore:main Apr 10, 2025
davidkoski added a commit that referenced this pull request Apr 10, 2025
davidkoski added a commit that referenced this pull request Apr 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants