add protocol for array + offset -- to be used by RoPE utils#322
Merged
davidkoski merged 2 commits intomainfrom Jan 8, 2026
Merged
add protocol for array + offset -- to be used by RoPE utils#322davidkoski merged 2 commits intomainfrom
davidkoski merged 2 commits intomainfrom
Conversation
4 tasks
awni
reviewed
Jan 8, 2026
Source/MLXNN/Module.swift
Outdated
Comment on lines
+1009
to
+1012
| /// A `Layer` (``Module`` subclass) that can be evaluated with an array and offset. | ||
| public protocol OffsetLayer: Module { | ||
| func callAsFunction(_ x: MLXArray, offset: Int) -> MLXArray | ||
| } |
Member
There was a problem hiding this comment.
This is so specific to RoPE.. it might make sense to put it in the same file..
|
OffsetLayer is also declared in Module.swift: mlx-swift/Source/MLXNN/Module.swift Line 1010 in 43531d7 @davidkoski this causes invalid redeclaration error |
4 tasks
davidkoski
added a commit
that referenced
this pull request
Jan 8, 2026
davidkoski
added a commit
that referenced
this pull request
Jan 9, 2026
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Adds a protocol:
This will be useful in the RoPE utils in mlx-swift-lm.
Checklist
Put an
xin the boxes that apply.pre-commit run --all-filesto format my code / installed pre-commit prior to committing changes