Skip to content

Revamp MLX C API#38

Merged
andresy merged 75 commits intomainfrom
revamp-struct
Nov 18, 2024
Merged

Revamp MLX C API#38
andresy merged 75 commits intomainfrom
revamp-struct

Conversation

@andresy
Copy link
Member

@andresy andresy commented Oct 9, 2024

This introduces the new API of MLX C

  • Less overheads on objects (no vtable, no refcount)
  • Return values are handled via (pointer) arguments
  • Better error management: C++ exceptions are now mostly captured, status is returned as an int value for most ops
  • Feels more like C: a number of C++ object wrapper disappeared (tuples, variants...)

andresy added 30 commits October 3, 2024 11:26
@andresy
c generator: use mlxtypes for return types
f905804
@andresy
revisit return arguments
9fecb37
@andresy
revisit closure support
e281dc1
@andresy
fix closure generation
8355596
@andresy
remove tuple class support
f5958b1
@andresy
remove ioutils
d7bf61e
@andresy
support for hooks and mlx_metal_device_info
9bfb747
@andresy
mlx_array_new()
4f9ff55
@andresy
fix example.c
fcbfc55
@andresy
support for ValueAndGradFn and mlx_value_and_grad
a08c735
@andresy
mlx_vector_set functions and remove vector of Dtype
89ed525
@andresy
tweak closure generation API with _new() and _from_...()
2b2ae38
@andresy
fix example-grad.c
e94232f
@andresy
fix example-safe-tensors.c
04f7fbb
@andresy
vector gen hot fix
67af3f0
@andresy
support for mlx_closure_metal_kernel
0325e63
@andresy
example using mlx_closure_metal_kernel
c8e09f1
@andresy
remove variant
372e7f2
@andresy
cmake minor cleanup
f20cc10
@andresy
mlx_array_dtype -> mlx_dtype
0cc441a
@andresy
main c generator: switch to new type handler
1b02031
@andresy
from -> new
69ea30a
@andresy
mlx_map: strings are now const char*
8a48c4e
@andresy
mlx_vector_string API is now with const char*
b5b55ca
@andresy
metal kernel: remove desc
e9e0f25
@andresy
improving mlx_fast_metal_kernel C API
836415c
@andresy
remove private/io.h
5db8641
@andresy
attempt to use pointers for return values
2ee8d43
@andresy
static empty array
7211fed
@andresy
improve map and vector apis (for returned values)
81e8717
davidkoski
davidkoski reviewed Oct 18, 2024
View reviewed changes
davidkoski
davidkoski reviewed Oct 18, 2024
View reviewed changes
davidkoski
davidkoski reviewed Oct 18, 2024
View reviewed changes
davidkoski
davidkoski approved these changes Nov 16, 2024
View reviewed changes
Copy link
Collaborator

@davidkoski davidkoski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. swift side is working

davidkoski added a commit to davidkoski/mlx-swift that referenced this pull request Nov 18, 2024
@davidkoski
checkpoint: adopt new mlx-c api - ml-explore/mlx-c#38
949e8d6
davidkoski added a commit to davidkoski/mlx-swift that referenced this pull request Nov 18, 2024
@davidkoski
checkpoint: adopt new mlx-c api - ml-explore/mlx-c#38
2cb8d73
@stemann stemann mentioned this pull request Nov 18, 2024
Merged
@andresy andresy merged commit a867ddc into main Nov 18, 2024
@andresy andresy deleted the revamp-struct branch November 18, 2024 21:19
@andresy andresy mentioned this pull request Nov 18, 2024
Closed
This was referenced Nov 19, 2024
Merged
Closed
davidkoski added a commit to davidkoski/mlx-swift that referenced this pull request Nov 20, 2024
@davidkoski
checkpoint: adopt new mlx-c api - ml-explore/mlx-c#38
fbff708
davidkoski added a commit to davidkoski/mlx-swift that referenced this pull request Dec 3, 2024
@davidkoski
checkpoint: adopt new mlx-c api - ml-explore/mlx-c#38
0afdac8
davidkoski added a commit to ml-explore/mlx-swift that referenced this pull request Dec 4, 2024
@davidkoski
[WIP] adopt new mlx-c api (#150)
bafcb33 
- adopt new mlx-c api - ml-explore/mlx-c#38
- mlx v0.21.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidkoski davidkoski davidkoski approved these changes

@angeloskath angeloskath Awaiting requested review from angeloskath

@awni awni Awaiting requested review from awni

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@andresy @davidkoski