fix: ensure dirname(config_file_path) is not empty#45
Merged
pawamoy merged 2 commits intomkdocstrings:masterfrom Nov 19, 2022
Merged
fix: ensure dirname(config_file_path) is not empty#45pawamoy merged 2 commits intomkdocstrings:masterfrom
pawamoy merged 2 commits intomkdocstrings:masterfrom
Conversation
Member
|
Argh, I guess I botched a release. Fine, let's fix that again. |
Member
|
v0.8.2 released 😓 |
Contributor
Author
|
Thanks for the super quick fix and release! :) |
viktorlashchuk
added a commit
to viktorlashchuk/mkdocstrings-python
that referenced
this pull request
Feb 24, 2025
PR #45: mkdocstrings/python#45 Co-authored-by: Timothée Mazzucotelli <pawamoy@pm.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using
os.chdirto switch to the directory containing the config file (introduced in #43) fails ifconfig_file_pathonly contains a filename but no directories (similar to timvink/mkdocs-table-reader-plugin#16). Replacing an empty result ofos.dirnameshould avoid this.