Fix edit link for autogenerated docs#443
Merged
pawamoy merged 6 commits intomkdocstrings:masterfrom Jun 26, 2022
Merged
Conversation
oprypin
reviewed
Jun 14, 2022
Member
|
Sorry for the troublesome hours 😅 And thank you so much for investigating and fixing this! |
Contributor
Author
Dont worry, different timezone, so I just woke up :) |
pawamoy
reviewed
Jun 18, 2022
pawamoy
reviewed
Jun 18, 2022
Co-authored-by: Timothée Mazzucotelli <pawamoy@pm.me>
pawamoy
reviewed
Jun 18, 2022
|
I had to rediscover this and i was about to open a similar merge request! Can you deploy the updated docs @pawamoy ? The live site still has the old version https://mkdocstrings.github.io/recipes/ |
Hnasar
pushed a commit
to Hnasar/mkdocstrings-python
that referenced
this pull request
Aug 24, 2022
We need to provide a relative path to go up out of the docs dir. See mkdocstrings/mkdocstrings#443
Member
|
Thanks for the reminder, I'll deploy the new docs 🙂 |
pawamoy
pushed a commit
to mkdocstrings/python
that referenced
this pull request
Sep 23, 2022
We need to provide a relative path to go up out of the docs dir. See mkdocstrings/mkdocstrings#443. Co-authored-by: Hashem Nasarat <hnasarat@beta.team>
viktorlashchuk
added a commit
to viktorlashchuk/mkdocstrings-python
that referenced
this pull request
Feb 24, 2025
We need to provide a relative path to go up out of the docs dir. See mkdocstrings/mkdocstrings#443. Co-authored-by: Hashem Nasarat <hnasarat@beta.team>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Been going crazy about this for the last couple of hours and unable to figure out for my personal docs and saw that this behaviour was also reproducible in the repo. Eventually found it and it is caused by the use of urllib.parse.urljoin in the gen_files plugin, which misinterprets the links if they are not ended in
/(@oprypin would you rather this gets fixed there instead?)Additionally, I noticed that the
edit_urimakes the edit links for the now correct links havedocs/as a base, which makes it link incorrectly, so I added a bit of a hacky fix to avoid thatAn example of the now broken page links can be seen here, where clicking on edit page leads to a 404.
EDIT: Would also like to add that both these issues can be seen across all other repositories for extensions for mkdocstrings