Change the styling of inline code and allow links to colorize inline code #12
Conversation
…code This is a port of mkdocs#772 to the Bootswatch themes.
|
This series of PR's looks great. I'll aim to review them in the next few days - thanks! |
|
Cool! If there are any changes you want me to make, just let me know. |
| padding: 1px 3px; | ||
| background: #ecf0f1; | ||
| border: solid 1px #ccc; | ||
| color: #7b8a8b; |
There was a problem hiding this comment.
The text colour here isn't great on that background. It doesn't stand out very much, I think the background should be lighter or the foreground darker.
There was a problem hiding this comment.
Yeah, I was debating what to do here. However, that's the color the theme uses for code blocks. In practice, you only see that color when not using highlight.js though (e.g. by setting the language to be nohighlight).
There was a problem hiding this comment.
Yeah, that's fair - it's probably okay, just a passing observation.
Change the styling of inline code and allow links to colorize inline code
|
I went ahead and merged this anyway, but I think the Flatly theme could benefit from a tweak for the inline code. It still looks 100x better than it did before tho' 🌟 |
This is a port of mkdocs/mkdocs#772 to the Bootswatch themes. I can provide screenshots for all the themes if you want.
The convention I used here is to use the code block's style for the light themes, and the sidebar's style for the dark themes. There are two reasons for this: 1) it looks nicer in my opinion, and 2) it works around an issue in Firefox where we need to have the link color for inline code be the same as the "normal" link color; otherwise the underline looks weird. It's a long story.
I also chose not to give a border around the inline code in the Cyborg theme because I think it looks nicer without the border.