Support <script type="module"> and other attributes
#3237
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Example of adding an `async` boolean option that can be read through `config['async']` or `config.async_`:
class ExampleConfig(Config):
async_ = Type(bool, default=False)
`SubConfig[SomeType]()` is now the preferred way to express `SubConfig(SomeType)` but more importantly, it is now possible to subclass `SubConfig[SomeType]` for post-processing of the value.
The top-level template object `extra_javascript` gets soft-deprecated because it still reports only a list of plain strings. Themes need to take action and pick up the new config keys from `config.extra_javascript` instead.
pawamoy
reviewed
Jun 3, 2023
squidfunk
approved these changes
Jun 4, 2023
Contributor
squidfunk
left a comment
There was a problem hiding this comment.
LGTM from eyeballing, but I didn't run the code. Only some minor questions/adjustment (see comments).
oprypin
commented
Jun 4, 2023
acodeninja
added a commit
to CPS-Innovation/digital-sop
that referenced
this pull request
Jul 27, 2023
acodeninja
added a commit
to CPS-Innovation/digital-sop
that referenced
this pull request
Jul 27, 2023
* Update dependency mkdocs to v1.5.0 * Correction to playbooks link * Adapt base template to work with new extended script object mkdocs/mkdocs#3237 --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Lawrence Goldstien <lawrence.goldstien@madetech.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.mjsfiles as JavaScript #3164See docs in the diff.
Try it out:
Particularly I'm hoping the frontend change of fiddling with
deferin standard themes doesn't cause problems.Frontend changes:
deferfor all scriptsSmall config features:
ListOfItems_from config members, to bypass Python reserved wordsSubConfig[T]Refactors:
tojsonfor pasting strings to JavaScriptSubConfigTemplateContexttyped, moveutils.filterstoutils.templatesThe actual change:
config.extra_javascriptto supporttype,async,deferjavascript_files()