Added an extra space to the readthedocs theme breadcrumbs. #2810
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oprypin
approved these changes
Mar 30, 2022
Contributor
oprypin
left a comment
There was a problem hiding this comment.
Thanks for spotting this! This is indeed a regression in 1.3.0.
I modified the fix, though. It was enough to add whitespace that isn't nbsp
ultrabug
approved these changes
Mar 31, 2022
howird
pushed a commit
to howird/mkdocs
that referenced
this pull request
May 14, 2022
Co-authored-by: Oleh Prypin <oleh@pryp.in>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the
readthedocstheme, the breadcrumbs of the last item needs an extra space.Before:
After:
I hope you don't mind I didn't open an issue first.