search plugin: do not crash on missing lang options, inform instead#2602
Merged
ultrabug merged 4 commits intomkdocs:masterfrom Oct 10, 2021
Merged
search plugin: do not crash on missing lang options, inform instead#2602ultrabug merged 4 commits intomkdocs:masterfrom
ultrabug merged 4 commits intomkdocs:masterfrom
Conversation
Member
ultrabug
commented
Oct 8, 2021
- fallback to english on missing search.lang option
- support search.lang territory pt_BR -> pt
- fallback to english on missing search.lang option - support search.lang territory pt_BR -> pt
Member
Author
|
This replaces #2564 to address your points #2535 (comment) with #2535 (comment) Example output: |
This was referenced Oct 8, 2021
oprypin
reviewed
Oct 8, 2021
oprypin
left a comment
There was a problem hiding this comment.
Thanks! The approach looks good to me. Let's get this done :)
CI is failing, though 😬
oprypin
reviewed
Oct 8, 2021
Member
Author
|
Fixing tests now, should be good soon |
Member
Author
|
Good for me now 👍 |
oprypin
reviewed
Oct 10, 2021
oprypin
approved these changes
Oct 10, 2021
Member
Author
|
Thanks for the review @oprypin |
This comment was marked as abuse.
This comment was marked as abuse.
Member
Author
|
Yes mate indeed, I'll check the pt_BR PR out later today, thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.