tox translation build: add tests for lunr.js language support#2564
Closed
ultrabug wants to merge 4 commits intomkdocs:masterfrom
Closed
tox translation build: add tests for lunr.js language support#2564ultrabug wants to merge 4 commits intomkdocs:masterfrom
ultrabug wants to merge 4 commits intomkdocs:masterfrom
Conversation
this should avoid forgetting that a locale added to mkdocs theme translations should be supported by lunr.js to work
Member
Author
Member
Author
|
Unless we want to disable the search plugin for missing locales with a WARNING log instead of crashing like mad? |
This comment was marked as abuse.
This comment was marked as abuse.
Member
Author
|
mkdocs-material does crash if you select a language it does not support |
update tox lunr.js check to only warn and not fail the CI
Member
Author
|
With latest commit, the search plugin will only WARN on unsupported lang configuration: Removing the offending locales from the search.lang config is fine since this config option allows to be empty and falls back to english anyway. I've made the tox CI to WARN as well but not fail the CI when a lunr locale is missing. If you're okay with this, I'll update the tests accordingly |
This comment was marked as abuse.
This comment was marked as abuse.
Member
Author
|
Moved to #2602 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this should avoid forgetting that a locale added to mkdocs theme
translations should be supported by lunr.js to work