Properly handle the scroll offset for anchors in the mkdocs theme; resolves #1931 #1935
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…solves mkdocs#1931 This patch uses `scroll-padding-top` to indicate that when the user clicks on an anchor and the browser scrolls to it, the anchor should have that amount of padding on the top, thus neatly accommodating the fixed nav header without any gross hacks!
737c935 to
b6e9d97
Compare
waylan
pushed a commit
to mkdocs/mkdocs-bootswatch
that referenced
this pull request
Jan 30, 2020
This patch uses `scroll-padding-top` to indicate that when the user clicks on an anchor and the browser scrolls to it, the anchor should have that amount of padding on the top, thus neatly accommodating the fixed nav header without any gross hacks!
waylan
pushed a commit
to mkdocs/mkdocs-bootswatch
that referenced
this pull request
Feb 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch uses
scroll-padding-topto indicate that when the user clicks on an anchor and the browser scrolls to it, the anchor should have that amount of padding on the top, thus neatly accommodating the fixed nav header without any gross hacks!Note: I used a padding of 70px to match the body's padding, rather than 75px as the old CSS hack used. Probably doesn't matter too much either way, but this seems more consistent...