Avoid background-attachment: fixed for better performance
#1395
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @yeraydiazdiaz - that works. For whatever reason when I was mucking around earlier, I couldn't get the styles to apply correctly. ¯\_(ツ)_/¯ |
Contributor
Author
|
Glad to hear that 👍 |
|
Also, not sure if it's worth adding a note explaining the change. eg, /* Replacement for `body { background-attachment: fixed; }`, which
has performance issues when scrolling on large displays. */ |
Member
|
Thank you @rpkilby for the report and suggested comment. And thank you @yeraydiazdiaz for the fix. |
waylan
added a commit
to waylan/mkdocs
that referenced
this pull request
Jul 10, 2018
The sidebar was under the left margin of the main content and not clickable. This moves the sidebar to the top so it is accessable. Not sure when this got broken. Maybe mkdocs#1387 or mkdocs#1389 or mkdocs#1395.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt at addressing #1394
I can't test it myself on a big screen, could @rpkilby or others test if it indeed solves the problem?