fix duplicate engine entries #5
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…moDS#14695) * reset page order - goes back to the first page when navigating away from the tab (on cancel only) * revert namespaces * revert namespaces
* disable cancel button of no changes - if there are no changes, disable the cancel button * revert namespaces * revert namespaces * rename button cancel to reset
- only UI related cherrypick which should not trigger any test issues
* upate * Update ViewExtension.cs * Update DocumentationBrowserView.xaml.cs * Update NotificationsViewExtension.cs * update * update * Update NotificationCenterController.cs * Test webview2 (DynamoDS#14670) * update * update * Update DocumentationBrowserView.xaml.cs * update * Update DocumentationBrowserView.xaml.cs * update * update --------- Co-authored-by: pinzart <tiberiu.pinzariu@autodesk.com> * Update NotificationCenterController.cs * Update DispatcherUtil.cs * Update CS_SDK.props * Revert "Update CS_SDK.props" This reverts commit cfaceb2. --------- Co-authored-by: pinzart <tiberiu.pinzariu@autodesk.com>
* DYN-6454 Update smoke test workflow * DYN-6454 Update smoke test workflow
- created an invisible border to occupy the title bar to help with dragging experience
* clear keywords on reset - now correctly clears the keyword pills on reset * namespace revert * revert namespaces
* DYN-6362 Refresh Packages Tour Bug I've added three validations for enabling the Dynamo UI when the Packages Tour is closed for preventing the UI Blocked bug. * DYN-6362 Refresh Packages Tour Bug Removing empty space
pinzart90
reviewed
Dec 7, 2023
| { | ||
| var options = new ObservableCollection<string> { Res.DefaultPythonEngineNone }; | ||
| foreach (var item in PythonEngineManager.Instance.AvailableEngines) | ||
| foreach (var item in PythonEngineManager.Instance.AvailableEngines.GroupBy(x=>x.Name).FirstOrDefault().ToList()) |
There was a problem hiding this comment.
were there multiple python engines with the same name ?
like 2 versions of Python2 at the same time?
Owner
Author
There was a problem hiding this comment.
yes, thats exactly the bug.
There was a problem hiding this comment.
so if we will support assembly isolation, then we could have the same pacakge but different versions loaded at the same time
So should we enforce uniqueness by appending the version to the engine name (internally at least)?
In the UI we could display the same name but tooltip would clarify which version. Or something like that ..
Co-authored-by: pinzart <tiberiu.pinzariu@autodesk.com>
* crash when uploading package - attempt to fix a crash when uploading a package and clearing the uploadhandle on success * revert namespaces * disable dispose during test * disable CancelCommandClearsAllData test - disabled CancelCommandClearsAllData test as the command it is supposed to be testing currently is restricted under testing environment as it crashes master-15 (sequentially running of tests) because of thread affinity issue
…namoDS#14711) - dynamo would issue a warning and fail to publish a package if an 'unqualified' file is being used, such as a dyf file already under package control - this check is done when publishing package locally, but I have incorrectly added it to the process of creating a build preview, which stops the process for both local and online submit workflow
Co-authored-by: pinzart <tiberiu.pinzariu@autodesk.com>
- now allows package version to start with 0 - cannot have 0.0.0 package version
* Fix PostDiff job * fix
Temporary set to net6 so we can get a net6 build with latest localization.
Revert back to net8.
* remove config * remove autogen stuff
…nitialized to null (DynamoDS#14703) * remove coreclr-ncalc references * add failing test for dropdown node * cleanup * update tests * attempt initial fix * cleanup * update test * review comments * add code comments
* Bump to 3.1 * Tweak * Bump year in algorithm to 2023. * Fix test * Hardening unittest
* remove legacy completion provider * remove * remove obsolete -arguable tests seem to pass going to merge this and cherry pick to 3.0
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TEMP PR until ironPythondotnet goes into DynamoDS/Dynamo