DYN-6519: clear keywords on reset #14696
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- now correctly clears the keyword pills on reset
QilongTang
reviewed
Dec 6, 2023
| using System.Runtime.InteropServices; | ||
| using System.Text.RegularExpressions; | ||
| using System.Windows; | ||
| using System.Windows.Forms; |
Contributor
There was a problem hiding this comment.
Did your settings for the sorting got reverted again?
Collaborator
Author
There was a problem hiding this comment.
Did they? I asked @reddyashish, I wasn't sure if the system ones should be on top or not. I did update Visual Studio recently, perhaps it reset the extension settings. I will re-update and push again, for all affected PRs.
Contributor
There was a problem hiding this comment.
QilongTang
approved these changes
Dec 6, 2023
Contributor
Contributor
|
Merge the upstream master branch here to fix the serialization tests. |
Contributor
|
Thanks @reddyashish @dnenov since the helix tests I dont think they have anything to do with this PR. Merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Addresses this jira issue: DYN-6519
Note
At the moment, the keyword
tags(bubbles, pills) are just decorative and are not taken into account when submitting the publish package form. The actual keyword values are still taken from the textbox input. Swapping with the current functionality requires a bit more work and cannot be done for 3.0 release.Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Reviewers
@reddyashish
FYIs
@avidit