Add Support for Mobile to the Data Sources Sidebar#405
Merged
Conversation
Add message on data source page when all techniques are hidden due to domain selected.
Make citation order stable.
Contributor
Author
|
Note: The commit message "Add ICS switch to data sources sidebar." is incorrect and should have been "Add Mobile switch to data sources sidebar". We regret the error. |
Contributor
Author
|
This pull request now includes additional fixes that:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds Mobile switch to data sources sidebar.
Adds a message on data source page when all techniques are hidden due to domain selected. This somewhat mitigates the problem that can occur when the user selects a data source and then changes the domain in the sidebar. Instead of just getting a blank area under the Data Components heading, they now get a short message explaining why there are no techniques listed.
There is still one issue with the domains that isn't addressed. The References at the bottom of the page are always the full set of references for all the data components/techniques, whether they are displayed or not. Fixing this will likely require a larger set of changes so has been deferred until later.
Closes #404