This repository was archived by the owner on Oct 31, 2023. It is now read-only.
Fixes #12 -- support running over multiple binaries#13
Merged
mitchellh merged 1 commit intomitchellh:masterfrom Sep 6, 2019
Merged
Fixes #12 -- support running over multiple binaries#13mitchellh merged 1 commit intomitchellh:masterfrom
mitchellh merged 1 commit intomitchellh:masterfrom
Conversation
mitchellh
approved these changes
Sep 6, 2019
| // Store the config and set it on the output | ||
| cfg = *c | ||
| } else { | ||
| exePaths = args[:1] |
Owner
There was a problem hiding this comment.
Nitpick: could just initialize this on L59 with exePaths := args[:1] right? avoid the else.
alex
added a commit
to alex/golicense
that referenced
this pull request
Sep 6, 2019
mitchellh
added a commit
that referenced
this pull request
Sep 6, 2019
Implement review feedback from #13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.