Adding a namespace for TinyDB in the companion#1111
Merged
jisqyv merged 5 commits intomit-cml:ucrfrom Feb 26, 2018
Merged
Conversation
ewpatton
requested changes
Jan 4, 2018
Member
ewpatton
left a comment
There was a problem hiding this comment.
You will also need to update versioning.js. Otherwise, users will get errors when loading a project that already contains TinyDB version 1.
| String webViewerComponentPallette(); | ||
|
|
||
| // Component Properties | ||
|
|
Contributor
Author
|
I think I need to update html document as well. |
Contributor
|
@ColinTree it would be great! |
Contributor
Author
|
@ewpatton I think this may be ready to be reviewed now~ |
ewpatton
requested changes
Feb 20, 2018
Member
ewpatton
left a comment
There was a problem hiding this comment.
One minor change and this will be good to go.
| @SimpleProperty(description = "Namespace for storing data.", category = PropertyCategory.BEHAVIOR) | ||
| @DesignerProperty(editorType = PropertyTypeConstants.PROPERTY_TYPE_TEXT, defaultValue = DEFAULT_NAMESPACE) | ||
| public void Namespace(String namespace) { | ||
| this.namespace=namespace; |
Contributor
Author
|
Done. @ewpatton |
ewpatton
approved these changes
Feb 26, 2018
ColinTree
pushed a commit
to ColinTree/appinventor-sources
that referenced
this pull request
Mar 4, 2018
pavi2410
pushed a commit
to pavi2410/appinventor-sources
that referenced
this pull request
Jun 18, 2018
bobbyluig
pushed a commit
to bobbyluig/appinventor-sources
that referenced
this pull request
Jan 9, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement #907