Skip to content

fix(frontend): ユーザー名が長い場合に、フォローボタンを折り返して表示させる#11326

Merged
syuilo merged 1 commit intomisskey-dev:developfrom
ryohidaka:fix/gallery-user-following-button-wrap
Jul 19, 2023
Merged

fix(frontend): ユーザー名が長い場合に、フォローボタンを折り返して表示させる#11326
syuilo merged 1 commit intomisskey-dev:developfrom
ryohidaka:fix/gallery-user-following-button-wrap

Conversation

@ryohidaka
Copy link
Contributor

@ryohidaka ryohidaka commented Jul 19, 2023

What

対応前 対応後
スクリーンショット 2023-07-19 23 50 45 スクリーンショット 2023-07-19 23 51 34

Why

  • フォローボタンの表示領域が少ない場合のデザイン崩れを防止するため。

Additional info (optional)

  • 回り込んだ後の位置は、既存踏襲の右寄せにしています。 (違和感をなくすため)
    • 位置に関して問題あれば、レビュワー担当者様と相談の上修正したいです。

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Jul 19, 2023
@codecov
Copy link

codecov bot commented Jul 19, 2023

Codecov Report

Merging #11326 (bd38bc2) into develop (af3258d) will increase coverage by 0.47%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop   #11326      +/-   ##
===========================================
+ Coverage    77.33%   77.80%   +0.47%     
===========================================
  Files          907      173     -734     
  Lines        91480    21648   -69832     
  Branches      7546      498    -7048     
===========================================
- Hits         70748    16844   -53904     
+ Misses       20732     4804   -15928     

see 764 files with indirect coverage changes

@syuilo syuilo merged commit 5e53b41 into misskey-dev:develop Jul 19, 2023
@syuilo
Copy link
Member

syuilo commented Jul 19, 2023

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

packages/frontend Client side specific issue/PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants