unify CLI & API under `minify()` by alexlamsl · Pull Request #1811 · mishoo/UglifyJS

alexlamsl · 2017-04-13T23:10:02Z

rename screw_ie8 to ie8
rename mangle.except to mangle.reserved
rename mangle.properties.ignore_quoted to mangle.properties.keep_quoted
compact sourceMap options
more stringent verification on input options
toplevel shorthands
- ie8
- keep_fnames
- toplevel
- warnings
support arrays and unquoted string values on CLI
drop fromString from minify()
- minify() no longer handles any fs operations
unify order of operations for mangle_properties() on CLI & API
- bin/uglifyjs used to mangle_properties() before even Compressor
- minify() used to mangle_properties() after Compressor but before mangle_names()
- both will now do Compressor, mangle_names() then mangle_properties()
options.parse / --parse for parser options beyond bare_returns
add mangle.properties.builtins to disable built-in reserved list
- disable with --mangle-props builtins on CLI
warnings now off by default
add --warn and --verbose on CLI
drop --enclose
drop --export-all
drop --reserved-file
- use --mangle reserved instead
drop --reserve-domprops
- enabled by default, disable with --mangle-props domprops
drop --prefix
- use --source-map base instead
drop --lint
remove bin/extract-props.js
limit exposure of internal APIs
update documentations

closes #96
closes #102
closes #136
closes #166
closes #243
closes #254
closes #261
closes #311
closes #700
closes #748
closes #912
closes #1072
closes #1366
fixes #101
fixes #123
fixes #124
fixes #263
fixes #379
fixes #419
fixes #423
fixes #461
fixes #465
fixes #576
fixes #737
fixes #772
fixes #958
fixes #1036
fixes #1142
fixes #1175
fixes #1220
fixes #1223
fixes #1280
fixes #1359
fixes #1368

alexlamsl · 2017-04-13T23:16:46Z

deprecated fromString in minify()
- minify() no longer handles any fs operations
unify order of operations for mangle_properties() on CLI & API
- bin/uglifyjs used to mangle_properties() before even Compressor
- minify() used to mangle_properties() after Compressor but before mangle_names()
- both will now do Compressor, mangle_names() then mangle_properties()

kzc · 2017-04-13T23:28:38Z

Ambitious PR!

Is there a doc for the source map options?

--source-map [options]

What do you plan to do with this misnamed CLI option which is related to mangle-props, not mangle?

--mangle-regex                Only mangle property names matching the regex

alexlamsl · 2017-04-13T23:32:50Z

Is there a doc for the source map options?

Will need to update README.md at some point... 😅

What do you plan to do with this misnamed CLI option which is related to mangle-props, not mangle?

Haven't done those yet, but basically I'll group them all under --mangle-props like I did with --source-map

kzc · 2017-04-13T23:39:23Z

So just to confirm, each module will only get the options pertinent to it rather than the topmost options reference?

i.e., compress.js will only get options.compress, ~~mangle.js~~ scope.js will only get options.mangle, etc?

Some options like warnings are cross concern. How will stuff like that be handled?

Edit: I guess parser.js could finally get its own options now.

alexlamsl · 2017-04-13T23:45:05Z

So just to confirm, each module will only get the options pertinent to it rather than the topmost options reference?

Yes - I handled the cross-domain options with shorthands at the moment, and have minify() propagate those into compress, mangle and output as applicable.

warnings is a special case in that it is actually AST_Node.warn_function which needs to be overridden appropriately. I've handled that for minify() and bin/uglifyjs, so they will output as an array and to stderr respectively.

kzc · 2017-04-13T23:48:18Z

Any reason why not pass the topmost options reference to all modules?

Compress could benefit by seeing an option in mangle in certain cases to facilitate better compression decisions, for example.

alexlamsl · 2017-04-13T23:52:05Z

Any reason why not pass the topmost options reference to all modules?

Just a matter of whether I can manage those changes. 😅

Once I'm comfortable with the current batch, I'll see if I can pass the common options to every stage.

alexlamsl · 2017-04-14T00:09:45Z

Edit: I guess parser.js could finally get its own options now.

Oops, I did forget to mention that in the commit logs, didn't I?

options.parse / --parse for parser options beyond bare_returns

- refactor `screw_ie8` to `ie8` - compact `sourceMap` options - more stringent verification on input `options` - toplevel shorthands - `ie8` - `keep_fnames` - `toplevel` - deprecated `fromString` in `minify()` - `minify()` no longer handles any `fs` operations - unify order of operations for `mangle_properties()` on CLI & API - `bin/uglifyjs` used to `mangle_properties()` before even `Compressor` - `minify()` used to `mangle_properties()` after `Compressor` but before `mangle_names()` - both will now do `Compressor`, `mangle_names()` then `mangle_properties()` - `options.parse` / `--parse` for parser options beyond `bare_returns` closes mishoo#96 closes mishoo#1366 fixes mishoo#124 fixes mishoo#263 fixes mishoo#379 fixes mishoo#423 fixes mishoo#576 fixes mishoo#737 fixes mishoo#958 fixes mishoo#1036 fixes mishoo#1175 fixes mishoo#1220 fixes mishoo#1223 fixes mishoo#1280

alexlamsl · 2017-04-14T07:53:39Z

@kzc 4a927b0 shows the current progress with bin/uglifyjs, alongside with source-map documentation as requested in #1811 (comment)

shortcut for `options.compress.warnings="verbose"`

update documentation

kzc · 2017-04-14T12:11:44Z

README.md

+    --config-file <file>        Read `minify()` options from JSON file.
+    -d --define <expr>[=value]  Global definitions.
+    --ie8                       Support non-standard Internet Explorer 8.
+                                Equivalent to setting `screw_ie8: false` in `minify()`


Is screw_ie8 still a minify option?

screw_ie8 does not exist within the codebase anymore - this part of the documentation has been updated in a subsequent commit as well.

kzc · 2017-04-14T12:31:57Z

I'll see if I can pass the common options to every stage.

I'm not so sure now if it's a good idea to pass topmost options to every stage. Put the idea on hold unless you think it has some merit and will not impact maintainability or performance.

alexlamsl · 2017-04-14T14:40:35Z

I'm not so sure now if it's a good idea to pass topmost options to every stage. Put the idea on hold unless you think it has some merit and will not impact maintainability or performance.

That's what I meant. Given that the change won't affect user-facing part of minify() (or bin/uglifyjs), it's safe to consider in a latter PR.

alexlamsl · 2017-04-14T14:52:56Z

So the items left to consider for bin/uglifyjs thus this PR are:

--lint _{(anybody saw uglify and thought it's about lint?)}
--reserved-file
--reserve-domprops _{(great - we can't even agree on past or present tense)}
--name-cache this should share serialisation code with --reserved-file

The rest are moved into their respective major switches and documented accordingly. And I got rid of that --prefix 3 source-map thing because frankly, I couldn't get my head round on how it's supposed to work intuitively, i.e. just write the path out with --sourcemap base=<path to truncate> and call it a day.

In terms of syntax sugar I've introduced -c warnings=verbose to be a shorthand of -c warnings="verbose" (obviously applies to string values in general). We also accept arrays now, so with the two combined you can do -c pure_funcs=[Math.cos,require] which should be less cumbersome than before. Oh and I deprecated hyphenated shorthands, i.e. -c pure-funcs will no longer work.

kzc · 2017-04-14T15:33:01Z

The linter can go as it doesn't work very well anyway. The angular-specific stuff should be dropped. Get all the flags to agree on tense and plurality.

Shouldn't warnings be moved to its own CLI flag --warnings as it'll apply to all modules? Ditto for warnings as topmost minify() option.

alexlamsl · 2017-04-15T14:19:39Z

Restarting test/ufuzz.js (was ~0.4MFuzz) - not that I expect anything to break, but no harm getting my ~~unpaid intern~~ box to do some work over Easter.

alexlamsl · 2017-04-15T14:21:52Z

Consider adding wording in README to discourage use of the low level API in favor of minify().

Add them around here? https://github.com/mishoo/UglifyJS2#the-hard-way

kzc · 2017-04-15T14:23:23Z

Yes.

Or consider not exporting low level API at all.

alexlamsl · 2017-04-15T14:24:39Z

Or consider not exporting low level API at all.

I'm more than happy to do that, to be honest.

kzc · 2017-04-15T14:30:23Z

Can you expose the low level API to tests only?

alexlamsl · 2017-04-15T14:37:11Z

Can you expose the low level API to tests only?

I'm thinking about that. I guess if I separate those from tools/exports.js into say tools/debug.js we should have them quite handy.

BTW, do you know what's the use for bin/extract-props.js?

remove unsupported features from documentation

alexlamsl · 2017-04-15T14:46:35Z

a70e9b0 removes ones that aren't even used by tests, but otherwise retain the rest albeit no longer mentioned under README.md

My thinking is now that they are declared as unsupported, we can remove them from the export list altogether in a latter PR.

kzc · 2017-04-15T14:53:17Z

BTW, do you know what's the use for bin/extract-props.js?

No idea.

alexlamsl · 2017-04-15T14:54:59Z

... you won't say a word if anything were to happen to it? 😏

kzc · 2017-04-15T14:55:31Z

Fine by me.

kzc · 2017-04-15T17:52:46Z

@alexlamsl Nice work!

Noticed that there are still references to the low level API in README. Search for "figure_out_scope".

alexlamsl · 2017-04-15T17:59:37Z

@kzc thanks for keeping an eye out as always 😉

Will open a new PR to fix up the docs in a moment.

avdg · 2017-04-16T19:47:06Z

Wishing to be able to configure the croak parameter in the minify function. For me it's a pain to maintain all these options on multiple versions of uglify :P

kzc · 2017-04-17T06:11:35Z

@alexlamsl How does one craft a 3.x CLI command to do the equivalent of this 2.x command?

$ echo 'var o = {foo:1, bar:2};' | uglifyjs --mangle-props
var o={a:1,b:2};

alexlamsl · 2017-04-17T06:14:34Z

@kzc this works on current master:

$ echo 'var o = {foo:1, bar:2};' | uglifyjs --mangle-props
var o={o:1,v:2};

kzc · 2017-04-17T06:17:52Z

@alexlamsl Nevermind - I didn't npm install to get commander.

alexlamsl · 2017-04-17T06:28:38Z

@kzc ah - I've got bitten by that once on the fuzzing box.

Otherwise I'm always thrilled to nuke node_modules just to watch it shrinks dramatically. 🍿 😎

There are actually a couple of improvements along the way, so we might as well. uglify-js 3 is a thing, but I’m not going up to it yet because of certain breaking changes that could potentially cause trouble: mishoo/UglifyJS#1811

There are actually a couple of improvements along the way, so we might as well. Although uglify-js 3 has [breaking changes], these do not affect Overture and should not affect anything that uses the Overture repository. [breaking changes]: mishoo/UglifyJS#1811

alexlamsl force-pushed the minify branch from be0aacd to 17b30aa Compare April 13, 2017 23:24

alexlamsl force-pushed the minify branch from 17b30aa to 0b5ce98 Compare April 13, 2017 23:31

alexlamsl force-pushed the minify branch from 1d40adb to 1749762 Compare April 14, 2017 00:07

alexlamsl force-pushed the minify branch from 1749762 to 1274aae Compare April 14, 2017 00:13

alexlamsl force-pushed the minify branch from 1274aae to 1a56c2f Compare April 14, 2017 00:35

abernix mentioned this pull request Apr 14, 2017

Msg when building "WARN: Output exceeds 32000 characters" meteor/meteor#8592

Closed

WIP: update README.md to reflect CLI progress

4a927b0

alexlamsl mentioned this pull request Apr 14, 2017

[WIP][3.x] Make minify portable by making it work without file system #1366

Closed

9 tasks

alexlamsl added 2 commits April 14, 2017 16:01

add --verbose

95e2ec8

shortcut for `options.compress.warnings="verbose"`

augment README with deprecated, undocumented options

7aad7fe

alexlamsl force-pushed the minify branch from dff1f78 to 7aad7fe Compare April 14, 2017 08:23

alexlamsl added 4 commits April 14, 2017 17:03

add --mangle-props

177c9a0

utilise public API for streams

3d9e9a1

add --source-map base

2af7323

update documentation

improve ease of use for --mangle except

e03c194

kzc reviewed Apr 14, 2017

View reviewed changes

limit exposure of internal API

a70e9b0

remove unsupported features from documentation

alexlamsl added 2 commits April 15, 2017 22:56

move TTY workaround to CLI

c14ff76

remove mysterious script

0d56d9d

alexlamsl merged commit ec443e4 into mishoo:master Apr 15, 2017

alexlamsl deleted the minify branch April 15, 2017 15:50

alexlamsl mentioned this pull request Apr 15, 2017

update README #1813

Merged

senhongo mentioned this pull request May 7, 2017

What is backwards incompatible in 3.0? #1875

Closed

azu mentioned this pull request May 8, 2017

Minify jser/report#6

Open

richardfrost mentioned this pull request Feb 2, 2018

Remove deprecated "fromString" from minify mrcoles/bookmarklet#8

Merged

Conversation

alexlamsl commented Apr 13, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alexlamsl commented Apr 13, 2017

Uh oh!

kzc commented Apr 13, 2017

Uh oh!

alexlamsl commented Apr 13, 2017

Uh oh!

kzc commented Apr 13, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alexlamsl commented Apr 13, 2017

Uh oh!

kzc commented Apr 13, 2017

Uh oh!

alexlamsl commented Apr 13, 2017

Uh oh!

alexlamsl commented Apr 14, 2017

Uh oh!

alexlamsl commented Apr 14, 2017

Uh oh!

kzc Apr 14, 2017

Choose a reason for hiding this comment

Uh oh!

alexlamsl Apr 14, 2017

Choose a reason for hiding this comment

Uh oh!

kzc commented Apr 14, 2017

Uh oh!

alexlamsl commented Apr 14, 2017

Uh oh!

alexlamsl commented Apr 14, 2017

Uh oh!

kzc commented Apr 14, 2017

Uh oh!

alexlamsl commented Apr 15, 2017

Uh oh!

alexlamsl commented Apr 15, 2017

Uh oh!

kzc commented Apr 15, 2017

Uh oh!

alexlamsl commented Apr 15, 2017

Uh oh!

kzc commented Apr 15, 2017

Uh oh!

alexlamsl commented Apr 15, 2017

Uh oh!

alexlamsl commented Apr 15, 2017

Uh oh!

kzc commented Apr 15, 2017

Uh oh!

alexlamsl commented Apr 15, 2017

Uh oh!

kzc commented Apr 15, 2017

Uh oh!

kzc commented Apr 15, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alexlamsl commented Apr 15, 2017

Uh oh!

avdg commented Apr 16, 2017

Uh oh!

kzc commented Apr 17, 2017

Uh oh!

alexlamsl commented Apr 17, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kzc commented Apr 17, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alexlamsl commented Apr 17, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

alexlamsl commented Apr 13, 2017 •

edited

Loading

kzc commented Apr 13, 2017 •

edited

Loading

kzc commented Apr 15, 2017 •

edited

Loading

alexlamsl commented Apr 17, 2017 •

edited

Loading

kzc commented Apr 17, 2017 •

edited

Loading