Closed
Conversation
previously test cases with the same name would be skipped except for the last one `test/run-test.js` will now report duplicated names as errors
Contributor
|
LGTM! |
Contributor
|
So it found another duplicate test name in test/compress/drop-console.js - the PR already paid for itself! |
Merged
alexlamsl
added a commit
to alexlamsl/UglifyJS
that referenced
this pull request
Feb 18, 2017
previously test cases with the same name would be skipped except for the last one `test/run-test.js` will now report duplicated names as errors closes mishoo#1461
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1451 (comment)
Throw in some new tests for
hoist_varsfor good measure - thought I'll put it here than #1460 as this is relatively low-risk (and non-breaking).