Preserve program completion value with enable_iife enabled#1293
Closed
rvanvelzen wants to merge 1 commit intomishoo:masterfrom
Closed
Preserve program completion value with enable_iife enabled#1293rvanvelzen wants to merge 1 commit intomishoo:masterfrom
rvanvelzen wants to merge 1 commit intomishoo:masterfrom
Conversation
Contributor
|
IIFEs are not the only constructs changed by uglify that would effect the completion value. If uglify does not preserve the completion value in the general case, why do it here? |
Contributor
|
It would be nice to have a compress option that could be disabled for standalone JS to not have this behavior. |
Contributor
|
Nix my comments above. I'm good with this PR. But in light of the discussion in #640 I think the compress default should be |
Closed
alexlamsl
added a commit
to alexlamsl/UglifyJS
that referenced
this pull request
Mar 1, 2017
Things like Angular Expression and Bookmarklet do not specify `return`, but implicitedly assumes the evaluated value from the final statement to be the return value. fixes mishoo#354 fixes mishoo#543 fixes mishoo#625 fixes mishoo#628 fixes mishoo#640 closes mishoo#1293
alexlamsl
added a commit
to alexlamsl/UglifyJS
that referenced
this pull request
Mar 2, 2017
Bookmarklet for instance implicitedly assumes a "completion value" without using `return`. The `expression` option now supports such use cases. Optimisations on IIFEs also enhanced. fixes mishoo#354 fixes mishoo#543 fixes mishoo#625 fixes mishoo#628 fixes mishoo#640 closes mishoo#1293
alexlamsl
added a commit
to alexlamsl/UglifyJS
that referenced
this pull request
Mar 3, 2017
Bookmarklet for instance implicitedly assumes a "completion value" without using `return`. The `expression` option now supports such use cases. Optimisations on IIFEs also enhanced. fixes mishoo#354 fixes mishoo#543 fixes mishoo#625 fixes mishoo#628 fixes mishoo#640 closes mishoo#1293
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #640