Skip to content

Add cs_of_distinguished_name#87

Merged
hannesm merged 1 commit intomirleft:masterfrom
reynir:cs_of_cert_subject
Sep 29, 2016
Merged

Add cs_of_distinguished_name#87
hannesm merged 1 commit intomirleft:masterfrom
reynir:cs_of_cert_subject

Conversation

@reynir
Copy link
Copy Markdown
Contributor

@reynir reynir commented Sep 25, 2016

This adds X509.Encoding.cs_of_cert_subject which is required for mirleft/ocaml-tls#332

@reynir
Copy link
Copy Markdown
Contributor Author

reynir commented Sep 25, 2016

The name cs_of_cert_subject is a bit misleading - It does not take a cert subject as argument. Is subject_cs_of_cert perhaps better?

@hannesm
Copy link
Copy Markdown
Member

hannesm commented Sep 26, 2016

what about cs_of_distinguished_name : distinguished_name -> Cstruct.t (you can extract with subject : cert -> distinguished_name the subject from a cert, and cs_of_distinguished_name might be useful in other contexts as well!?!?

@reynir
Copy link
Copy Markdown
Contributor Author

reynir commented Sep 26, 2016

Great! I didn't realize the type of Asn_grammars.Name.name_to_cstruct is exactly distinguished_name -> Cstruct.t. I will update later today.

@hannesm
Copy link
Copy Markdown
Member

hannesm commented Sep 27, 2016

could you please squash the commits into a single one? (and i'm off for sleep + transrussian flight, don't expect activity from me within the next 36 hours)

@reynir reynir changed the title Add cs_of_cert_subject Add css_of_distinguished_name Sep 27, 2016
@hannesm
Copy link
Copy Markdown
Member

hannesm commented Sep 29, 2016

thanks!

@hannesm hannesm merged commit 6f70fb7 into mirleft:master Sep 29, 2016
@reynir reynir changed the title Add css_of_distinguished_name Add cs_of_distinguished_name Apr 11, 2017
@hannesm hannesm mentioned this pull request Apr 2, 2019
hannesm added a commit to hannesm/opam-repository that referenced this pull request Apr 2, 2019
CHANGES:

* provide X509.Encoding.distinguished_name_of_cs -- similar to mirleft/ocaml-x509#87 which provided distinguished_name_to_cs
* provide X509.Encoding.{public_key_of_cstruct,public_key_to_cstruct}, as requested by @dinosaure
* support of cstruct 4.0.0, which split up the sexp de&encoders
* removes result dependency (now requires >= 4.04.2)
* upgrades opam file to version 2.0
* build system is now dune
yomimono pushed a commit to yomimono/opam-repository that referenced this pull request Apr 5, 2019
CHANGES:

* provide X509.Encoding.distinguished_name_of_cs -- similar to mirleft/ocaml-x509#87 which provided distinguished_name_to_cs
* provide X509.Encoding.{public_key_of_cstruct,public_key_to_cstruct}, as requested by @dinosaure
* support of cstruct 4.0.0, which split up the sexp de&encoders
* removes result dependency (now requires >= 4.04.2)
* upgrades opam file to version 2.0
* build system is now dune
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants