Merged
Conversation
on the client, if a client certificate was used, this was included in the transcript -- we now call it earlier on the server, an empty master secret was used, so the exporter secret never matched this has been validated with the OCaml-TLS implementation itself (now, a client and server talking to each other compute the same exporter secret). also a "openssl s_server" with a "test_client.exe" using TLS 1.3 compute the very same exporter key material now.
Member
Author
|
I tested this with miragevpn -- before this PR, our server couldn't use tls-ekm with our client - with this PR, it can! :) |
raphael-proust
pushed a commit
to ocaml/opam-repository
that referenced
this pull request
May 15, 2024
CHANGES: * tls: documentation: clarify send_application_data (mirleft/ocaml-tls#492 @reynir) * BUGFIX: tls: export_key_material was wrong for the server side on TLS 1.3, reported in robur-coop/miragevpn#181 by @reynir, fix in mirleft/ocaml-tls#495 @hannesm * FEATURE: tls: add channel_binding (RFC 5929, RFC 9266) support (tls_unique, tls_exporter, tls_server_endpoint), requested by @Neustradamus in mirleft/ocaml-tls#484, added in mirleft/ocaml-tls#496 by @hannesm
dinosaure
added a commit
to dinosaure/ocaml-tls
that referenced
this pull request
Jun 27, 2024
Merged
dinosaure
added a commit
to dinosaure/ocaml-tls
that referenced
this pull request
Jul 22, 2024
hannesm
pushed a commit
to dinosaure/ocaml-tls
that referenced
this pull request
Aug 19, 2024
hannesm
pushed a commit
to dinosaure/ocaml-tls
that referenced
this pull request
Aug 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
//cc @reynir