[wip] rel 3.0.0 with soft sexp dependency and result types#79
Merged
avsm merged 19 commits intomirage:masterfrom Jan 2, 2019
Merged
[wip] rel 3.0.0 with soft sexp dependency and result types#79avsm merged 19 commits intomirage:masterfrom
avsm merged 19 commits intomirage:masterfrom
Conversation
Signed-off-by: Anil Madhavapeddy <anil@recoil.org>
Signed-off-by: Anil Madhavapeddy <anil@recoil.org>
Signed-off-by: Anil Madhavapeddy <anil@recoil.org>
…he `Ipaddr` module can be wrapped. Signed-off-by: Anil Madhavapeddy <anil@recoil.org>
Also add a scope converter to/from strings
These are compatible with ppx_sexp_conv and Sexplib0
Signed-off-by: Anil Madhavapeddy <anil@recoil.org>
Signed-off-by: Anil Madhavapeddy <anil@recoil.org>
also fix up test cases Signed-off-by: Anil Madhavapeddy <anil@recoil.org>
Signed-off-by: Anil Madhavapeddy <anil@recoil.org>
avsm
added a commit
to avsm/opam-repository
that referenced
this pull request
Dec 26, 2018
in preparation for mirage/ocaml-ipaddr#79 in ipaddr 3.0.0
Signed-off-by: Anil Madhavapeddy <anil@recoil.org>
avsm
added a commit
to avsm/ocaml-conduit
that referenced
this pull request
Dec 26, 2018
see mirage/ocaml-ipaddr#79 Signed-off-by: Anil Madhavapeddy <anil@recoil.org>
This was referenced Dec 26, 2018
Member
Author
|
cc @dinosaure in case you use this library in mrmime and have any opinions |
hannesm
reviewed
Jan 1, 2019
| - `ipaddr.top`: Toplevel printers for Ipaddr. | ||
| - `macaddr.top`: Toplevel printers for Macaddr. | ||
| - `ipaddr.sexp`: S-expression converters for Ipaddr. | ||
| - `macaddr.sexp`: S-expression converters for Macaddr. |
Member
There was a problem hiding this comment.
there's as well ipaddr.unix last time i looked - it should be added here
Member
|
this looks good to me, just two minor comments for README. would appreciate this to be merged and have a 3.0 release together with #80 (certainly 3.0 will break several reverse deps, but we can fix them after release) |
hannesm
reviewed
Jan 1, 2019
| # ipaddr: IP (and MAC) address manipulation | ||
|
|
||
| A library for manipulation of IP (and MAC) address representations. | ||
| A library for manipulation of IP and MAC address representations. |
Member
There was a problem hiding this comment.
in line 1, we should remove the parens as well imho
Member
Author
There was a problem hiding this comment.
thanks updated the README more generally in 8e2fc40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just still finishing this of but wanted to preview the PR. This release features several backwards incompatible changes, but ones that should increase the portability and robustness of the library. Requested by @hannesm for smaller unikernels.
ppfunctions. Use theIpaddr_sexpmodule if you still need a sexp serialiser.Macaddrmodule into a separate opam package so that theIpaddrmodule can be wrapped.of_string/bytesfunctions that formerly returned option types with theRresultresult types instead.pp_humwhich was deprecated in 2.9.0.