dns_certify_mirage: use a pair instead of two separate arguments for the dns-key#357
Merged
hannesm merged 1 commit intomirage:mainfrom Nov 4, 2024
Merged
dns_certify_mirage: use a pair instead of two separate arguments for the dns-key#357hannesm merged 1 commit intomirage:mainfrom
hannesm merged 1 commit intomirage:mainfrom
Conversation
…the dns-key The reason is that the Dns.Dnskey.name_key_of_string return exactly that pair, and user code then looks nice :)
hannesm
added a commit
to hannesm/opam-repository
that referenced
this pull request
Feb 7, 2025
CHANGES: * dns-certify: use a pair instead of two separate arguments for the dns-key (mirage/ocaml-dns#357 @hannesm) * add KSK 2024 (mirage/ocaml-dns#358 @hannesm) * update to mirage-crypto 1.2.0 API changes (mirage/ocaml-dns#362 @hannesm) * use dune variants, avoid functors (mirage/ocaml-dns#363 @hannesm)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The reason is that the Dns.Dnskey.name_key_of_string return exactly that pair, and user code then looks nice :)