Skip to content

Customize the application of password#4

Closed
dinosaure wants to merge 1 commit intomirage:masterfrom
dinosaure:dinosaure-ssl
Closed

Customize the application of password#4
dinosaure wants to merge 1 commit intomirage:masterfrom
dinosaure:dinosaure-ssl

Conversation

@dinosaure
Copy link
Copy Markdown
Member

Hello,

We need a function for the demand of password for SSL certificate in Ocsigenserver. But, I think this PR is not perfect (must I use a polymorphic variant for specify password ?).

@avsm
Copy link
Copy Markdown
Member

avsm commented May 20, 2014

Agreed; will merge this with the rest just as soon as I can finish the code review (this week I hope)

avsm added a commit to avsm/ocaml-conduit that referenced this pull request May 27, 2014
@avsm
Copy link
Copy Markdown
Member

avsm commented May 27, 2014

I've put in a Password and No_password explicit variant in the patch in order to match the rest of the interface. Will be merged into trunk shortly with the rest of the refactoring branch.

@avsm
Copy link
Copy Markdown
Member

avsm commented May 31, 2014

merged into trunk; not supported in async due to limitation of async_ssl for now

@avsm avsm closed this May 31, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants