Skip to content

Add sockaddr information to callback#2

Closed
dinosaure wants to merge 1 commit intomirage:masterfrom
dinosaure:master
Closed

Add sockaddr information to callback#2
dinosaure wants to merge 1 commit intomirage:masterfrom
dinosaure:master

Conversation

@dinosaure
Copy link
Copy Markdown
Member

@dinosaure dinosaure commented May 9, 2014

PR it's in relation with mirage/ocaml-cohttp#140

@dinosaure dinosaure mentioned this pull request May 14, 2014
Closed
@rgrinberg
Copy link
Copy Markdown
Member

rgrinberg commented May 17, 2014

+1 looks reasonable to me.

avsm added a commit to avsm/ocaml-conduit that referenced this pull request May 27, 2014
@avsm
Add a conn value to the callback to query more information about th…
e54ae63 
…e current connection

This is preferable to the solution in mirage#2 since it is extensible to other types of
connections in the future, such as shared memory (which will not fit into the sockaddr
model).
@avsm
Copy link
Copy Markdown
Member

avsm commented May 27, 2014

I've added a level of abstraction to this in avsm/ocaml-conduit@e54ae63

We define a conn abstract type that can be queried for this information. This also lets our callback interfaces be symmetric for clients and servers, and doesn't impose a syscall on the common path. It also lets Conduit remain extensible for non-Unix standard transports, such as a shared memory one (which wont fit into a sockaddr).

@avsm
Copy link
Copy Markdown
Member

avsm commented May 31, 2014

fixed using an alternative implementation in trunk

@avsm avsm closed this May 31, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dinosaure @rgrinberg @avsm