Fix issue #448 after breakage from PR #447#449
Merged
rgrinberg merged 1 commit intomirage:masterfrom Dec 20, 2015
Merged
Conversation
Member
|
Looks good. Can we somehow incorporate @edwintorok 's report into a test? I would love it if we could test for this regression in the future. |
Contributor
Author
|
Would you prefer a test that calls out to |
Contributor
|
Reproducing the issue with Cohttp's client and server would be useful. |
Merged
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't close ic/oc immediately as they may still be in use when reading body content.