serialize to a stream#1
Merged
1 commit merged intomirage:masterfrom Sep 15, 2010
jaked:f70024373bcea2f222b0f4828654309fa876c664
Merged
serialize to a stream#11 commit merged intomirage:masterfrom jaked:f70024373bcea2f222b0f4828654309fa876c664
1 commit merged intomirage:masterfrom
jaked:f70024373bcea2f222b0f4828654309fa876c664
Conversation
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here is the cohttp half of the change we discussed to hide the output channel from the handler, so that different handler invocations can't interfere. It renames
serializetoserialize_to_output_channeland adds a newserialize_to_streamfunction, in bothHttp_messageandHttp_response. You can see inserialize_to_streamthat in thewrite_from_exactlycase the buffer is copied.