This repository was archived by the owner on May 8, 2024. It is now read-only.
Rename ethif to ethernet#16
Merged
hannesm merged 1 commit intomirage:masterfrom Feb 24, 2019
hannesm:rename-ethif
Merged
Conversation
This was referenced Feb 20, 2019
Member
Author
|
a mirage-dev branch that utilizes the above mentioned PR is compiling fine, see https://travis-ci.org/mirage/mirage-dev/builds/496662474 for results. the individual PRs are not compiling since their travis.yml does not point to the mirage-dev branch in question (I don't think it is worth it for the rename). |
hannesm
added a commit
to hannesm/opam-repository
that referenced
this pull request
Feb 24, 2019
CHANGES: - Ethif/ETHIF renamed to Ethernet/ETHERNET (mirage/mirage-protocols#16) - Ethernet.proto defines a polymorphic variant of ethernet types (mirage/mirage-protocols#15) - Ip.proto defines a polymorphic variant of ip types (mirage/mirage-protocols#15) - Ethernet.writev is removed (mirage/mirage-protocols#15) - Ethernet.write expects an optional source mac address, a destination mac address, a protocol, an optional size and a fill function. Ethernet writes the Ethernet header to the buffer. (mirage/mirage-protocols#15) - Ip.writev and Ip.checksum are removed (mirage/mirage-protocols#15) - Ip.write expects an optional fragment, ttl, src, and a size and fill function, as well as a list of payload buffers. Size default to MTU. (mirage/mirage-protocols#15) - migrated build system to dune
hannesm
added a commit
to hannesm/opam-repository
that referenced
this pull request
Feb 24, 2019
CHANGES: - Ethif/ETHIF renamed to Ethernet/ETHERNET (mirage/mirage-protocols#16) - Ethernet.proto defines a polymorphic variant of ethernet types (mirage/mirage-protocols#15) - Ip.proto defines a polymorphic variant of ip types (mirage/mirage-protocols#15) - Ethernet.writev is removed (mirage/mirage-protocols#15) - Ethernet.write expects an optional source mac address, a destination mac address, a protocol, an optional size and a fill function. Ethernet writes the Ethernet header to the buffer. (mirage/mirage-protocols#15) - Ip.writev and Ip.checksum are removed (mirage/mirage-protocols#15) - Ip.write expects an optional fragment, ttl, src, and a size and fill function, as well as a list of payload buffers. Size default to MTU. (mirage/mirage-protocols#15) - migrated build system to dune
hannesm
added a commit
to hannesm/opam-repository
that referenced
this pull request
Feb 24, 2019
CHANGES: - Ethif/ETHIF renamed to Ethernet/ETHERNET (mirage/mirage-protocols#16) - Ethernet.proto defines a polymorphic variant of ethernet types (mirage/mirage-protocols#15) - Ip.proto defines a polymorphic variant of ip types (mirage/mirage-protocols#15) - Ethernet.writev is removed (mirage/mirage-protocols#15) - Ethernet.write expects an optional source mac address, a destination mac address, a protocol, an optional size and a fill function. Ethernet writes the Ethernet header to the buffer. (mirage/mirage-protocols#15) - Ip.writev and Ip.checksum are removed (mirage/mirage-protocols#15) - Ip.write expects an optional fragment, ttl, src, and a size and fill function, as well as a list of payload buffers. Size default to MTU. (mirage/mirage-protocols#15) - migrated build system to dune
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
netif(mirage-net) is our network device. ethernet is the ethernet layer.this PR is on top of #15 and should be merged thereafter (but before a 2.0 release :)). required reverse dependency updates: