This repository was archived by the owner on Oct 18, 2020. It is now read-only.
Merged
Conversation
It seems that the "right" value for this is 26 from https://github.com/ocaml/ocaml/blob/70d880a41a82aae1ebd428fd38100e8467f8535a/byterun/caml/mlvalues.h#L97 .
Contributor
Author
|
Got an LGTM from @hannesm via IRC and a |
Member
|
The |
Member
|
oh, I guess we can now claim to be a "xen" or "whateveryoulikebutnotunix" platform, since ocaml/ocaml#674 got into 4.04! (we should do this, and as well in ocaml-freestanding /cc @mato) -- this is unless it breaks elsewhere |
Contributor
Author
Contributor
Author
|
@hannesm: file an issue for that? I think it will be forgotten as a comment on a merged PR. |
TheLortex
pushed a commit
to TheLortex/mirage-platform
that referenced
this pull request
Feb 14, 2019
a844d58 Merge pull request mirage#176 from JuliaLang/aa/openbsd 72bfab4 Avoid redefining macros defined by the system 48c6c2c Use cp -RpP instead of cp -a bf188ae Build with Clang on OpenBSD b7b3b4b Merge pull request mirage#175 from takuyanakaoka/fix-sincosl d134c84 Fix reversed outputs of sincosl c99ab08 Merge pull request mirage#173 from pkofod/patch-1 3db5e54 Minor typo in expm1 comment b252047 Merge pull request mirage#168 from JuliaLang/yyc/ld128 238a909 Fix compilation on AArch64 3ff5216 Merge pull request mirage#162 from JuliaLang/aa/0.5.5 7cf4e9e Merge pull request mirage#164 from iblis17/test-cflags bd6d0e1 test: update ulps for yn 400407e test: append $(CFLAGS_add), which includes fno-builtin ddf649b enable -fno-strict-aliasing for clang (mirage#156) c3968ca Allow building on DragonFly BSD (mirage#167) 7e726c3 Bump version to 0.5.5 b11e72b Set the RPATH for the test binaries on FreeBSD (mirage#161) git-subtree-dir: openlibm git-subtree-split: a844d584d36fcb117c7880d87b806ff84b20f378
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows
mirage-xen-ocamlto be installed on switches using 4.04.0 , and unikernels built in that configuration to boot and run under xen. I admit to having very little idea what I'm doing here, and I'd appreciate a review of these changes.Fixes #173 .