constrain type t to unit#38
Merged
avsm merged 1 commit intomirage:masterfrom Dec 27, 2018
hannesm:t-is-unit
Merged
Conversation
Member
|
lgtm, merged! |
avsm
added a commit
to avsm/opam-repository
that referenced
this pull request
Dec 27, 2018
…wt and mirage-clock-unix (2.0.0) CHANGES: * Constrain the clock type `t` to `unit` to improve compatability with the webmachine CLOCK interface. All current implementations satisfy this interface so there shouldn't be an issue, but bumping the library major version number to reflect the interface change (mirage/mirage-clock#38 @hannesm) * Port library to Dune from jbuilder and use `dune-release` and the builtin `dune.configurator` to reduce the build dependency cone (mirage/mirage-clock#39 @avsm). * Remove unused variable warnings (mirage/mirage-clock#39 @avsm). * Update opam package metadata to 2.0 format (mirage/mirage-clock#39 @avsm). * Fixes to the ocamldoc comment headers for odoc compatibility (@avsm)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
there are some reasons for proposing this change
(a) all implementations satisfy this interface
(b) each unikernel will ever only have a single mclock / pclock
(c) it is more compatible with ocaml-webmachine clock interface
this change is fully backward-compatible.
//cc @linse @samoht @dinosaure