Skip to content

Travis: Run apt update before calling apt install#840

Closed
g2p wants to merge 1 commit intomirage:masterfrom
g2p:travis-apt-fix
Closed

Travis: Run apt update before calling apt install#840
g2p wants to merge 1 commit intomirage:masterfrom
g2p:travis-apt-fix

Conversation

@g2p
Copy link
Copy Markdown
Contributor

@g2p g2p commented Jun 18, 2017

No description provided.

@g2p g2p changed the title Run apt update before calling apt install (through opam depext) Travis: Run apt update before calling apt install Jun 18, 2017
@@ -1,4 +1,5 @@
eval `opam config env`
sudo apt update
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

normally the depext -u below should run apt update:

$ opam depext --help

    -u, --update
           Update the OS package sets before installation

Do you have some logs where this is broken?

Copy link
Copy Markdown
Contributor Author

@g2p g2p Jun 19, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, good point. Here's my log: https://travis-ci.org/mirage/mirage/jobs/244219628. It's not triggered the first time because the packages are already there, and after that the flag is missing.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it should be added to mirage-skeleton depext calls then.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh wait, it has to be added to a make depend target that's generated by mirage itself.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #841. It's a more intrusive change but probably the right thing to do.

g2p added a commit to g2p/mirage that referenced this pull request Jun 19, 2017
This is more reliable.  The update won't be triggered if all packages are
installed.

Alternative to mirage#840.
g2p added a commit to g2p/mirage that referenced this pull request Jun 19, 2017
This is more reliable.  The update won't be triggered if all packages are
installed.

Alternative to mirage#840.
@g2p
Copy link
Copy Markdown
Contributor Author

g2p commented Jun 20, 2017

Running apt update is currently broken due to the Stretch release (testing is now an alias for buster and not stretch, and that breaks things — https://travis-ci.org/mirage/mirage/jobs/244459518).
Probably something that needs to be fixed at the Docker image level.

@avsm
Copy link
Copy Markdown
Member

avsm commented Jun 20, 2017

I'm taking a look at the Docker base images.

djs55 pushed a commit to g2p/mirage that referenced this pull request Jul 19, 2017
This is more reliable.  The update won't be triggered if all packages are
installed.

Alternative to mirage#840.
@samoht
Copy link
Copy Markdown
Member

samoht commented Jul 20, 2017

Closing as the other PR is now in.

@samoht samoht closed this Jul 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants