This repository was archived by the owner on Aug 25, 2022. It is now read-only.
Merged
Conversation
Member
|
CI should be fixed by ocaml/ocaml-ci-scripts#71 |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds:
Env setting with latest cmdliner. I choose to have something more simple, documentation wise, by just using the default (which redirects to the key). I personally thing it's far enough.
Otherwise, not much to say, it works perfectly well, including at runtime.
flag and proxy keys: Wow, that was very painful. The internal is much more powerful than what is exposed, but what is exposed is the only part that doesn't have any weird quiks.
The priority is well behaved, if
--deployset, among other things,ipand you do--deploy --ip FOO, it's going to work as expected. I do not garantee anything if two proxies step on each other toes (noteven a warning, at the moment ...).
One weirdness, which is somehow expected but still slightly annoying, is that if I have
--xensetting-t xen. ThenBootvar_gen.xen () = trueonly if--xenwas passed. Not if-t xenwas passed.It makes sense, because of the deploy example I gave previously.
What is forbidden by the API because too quirky: