Skip to content
This repository was archived by the owner on Aug 25, 2022. It is now read-only.

Various improvement to keys#24

Merged
samoht merged 4 commits intomirage:masterfrom
Drup:superkeys
Oct 3, 2015
Merged

Various improvement to keys#24
samoht merged 4 commits intomirage:masterfrom
Drup:superkeys

Conversation

@Drup
Copy link
Copy Markdown
Member

@Drup Drup commented Oct 3, 2015

This adds:

Env setting with latest cmdliner. I choose to have something more simple, documentation wise, by just using the default (which redirects to the key). I personally thing it's far enough.
Otherwise, not much to say, it works perfectly well, including at runtime.

flag and proxy keys: Wow, that was very painful. The internal is much more powerful than what is exposed, but what is exposed is the only part that doesn't have any weird quiks.

The priority is well behaved, if --deploy set, among other things, ip and you do --deploy --ip FOO, it's going to work as expected. I do not garantee anything if two proxies step on each other toes (not
even a warning, at the moment ...).

One weirdness, which is somehow expected but still slightly annoying, is that if I have --xen setting -t xen. Then Bootvar_gen.xen () = true only if --xen was passed. Not if -t xen was passed.

It makes sense, because of the deploy example I gave previously.

What is forbidden by the API because too quirky:

  • non-flag proxies, because I have no idea what semantic to give them, when no value is given.
  • runtime proxies, because it's not going to be possible with printf-CSP

@samoht
Copy link
Copy Markdown
Member

samoht commented Oct 3, 2015

CI should be fixed by ocaml/ocaml-ci-scripts#71

@samoht samoht mentioned this pull request Oct 3, 2015
samoht added a commit that referenced this pull request Oct 3, 2015
Various improvement to keys
@samoht samoht merged commit dca31a4 into mirage:master Oct 3, 2015
@Drup Drup deleted the superkeys branch October 31, 2015 16:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants