Merged
Conversation
behavioural change is that unsolicited ARP frames are dropped in this implementation in contrast to mirage-tcpip's one. minor changes: - provide Arp_handler.ips : t -> Ipaddr.V4.t list (for testing etc.) - remove unused Clock : Mirage_clock.MCLOCK from arp-mirage functor - provide Arp_packet.equal
Member
Author
|
force-pushed, ready to merge if travis agrees |
Member
Author
|
while trying to remove arp from tcpip, i discovered cyclic opam dependencies in tests :/ good news is that arp only depends on ethernet for testing, which I split off into mirage/ethernet... |
avsm
added a commit
to avsm/opam-repository
that referenced
this pull request
Feb 2, 2019
CHANGES: * split opam package into two separate ones: a core `arp` package and the `arp-mirage` implementation for MirageOS that has more dependencies. This eliminates the use of depopts that was done previously to build the Mirage layer. (mirage/arp#7 @avsm) * port build system to Dune (mirage/arp#7 @avsm). The `make coverage` and `make bench` targets will do the job of the previous topkg targets for those. * minor fixes to ocamldoc comments to be compatible with odoc. * use mirage-random and mirage-random-test instead of a nocrypto dependency in tests and bench (mirage/arp#7 @hannesm) * import tests from mirage-tcpip (mirage/arp#8 @hannesm) * depend on the ethernet opam package, no longer provided by tcpip >3.7.0 (mirage/arp#9 @hannesm)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
also stumbled upon an exception in mirage-vnetif, pinning a branch thereof which does not raise (not sure what the actual problem is, already spent 3 hours in debugging this)