Conversation
fixed path for komodo-cli
Update verus
Release v2.0.1
Merge dev branch for Sapling, nothing at stake, and many fixes/updates into VerusCoin
On Mac, force 64 bit as needed
Fix incorrect voutNum and ensure that voutNum is of output with value
Use the 64 bit reverser, the only one provided.
Sync Overwinter and Sapling defaults
Fix Komodo compatibility
…itcartel Closes zcash#3467. Add benchmarks for Sapling spends and outputs. Four new benchmarks are added to RPC zcbenchmark: - createsaplingspend - createsaplingoutput - verifysaplingspend - verifysaplingoutput
Fix error message This error should never happen, but it may as well reference the method it is thrown from.
Adding missing batch scripts
Fix potentially misleading test failures This is in response to zcash#3590 (comment) Currently statements such as: ```assert_equal("Embarassment", "Embarrassment", "Misspelling detected")``` Will produce essentially the following error: ``` Assertion failed: Misspelling detected; expected: <Embarassment> but was: <Embarrassment> File "/home/eirik/Development/zcash/qa/rpc-tests/test_framework/test_framework.py", line 121, in main self.run_test() File "/home/eirik/Development/zcash/qa/rpc-tests/test_spelling.py", line 13, in run_test ``` Which is misleading because the item on the left is not what is actually expected. This PR changes the assertion failure to be displayed as: ``` Assertion failed: (left == right); Misspelling detected left: <Embarassment> right: <Embarrassment> File "/home/eirik/Development/zcash/qa/rpc-tests/test_framework/test_framework.py", line 121, in main self.run_test() File "/home/eirik/Development/zcash/qa/rpc-tests/test_spelling.py", line 13, in run_test ```
The only upstream change relative to the previous commit is that the various Zcash-specific dependencies have been pulled into a cargo workspace. The dependecies in the workspace use the same commits as the crates we had previously vendored. The patches are necessary to handle the fact that cargo requires that dev dependencies are available even if not used, and we would otherwise need to vendor all the underlying crates.
This ensures that the depends system's custom PATH is applied correctly, and the pre-build Rust binaries are accessible.
Pass parameter paths as native strings to librustzcash Fixes a user-reported crash when starting on Windows with a Cyrillic non-UTF-8 locale.
Moving verus.bat from src to scr/fiat Adjusting gitlab-ci configuration and Mac release packaging script to comform to the changes.
CI update
Updating package configuration from zcash
…me locked coinbases. Cheat catcher
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.