Add former default gems as a dependency for Ruby 3.1 compatibility by casperisfine · Pull Request #1439 · mikel/mail

casperisfine · 2021-05-28T07:24:59Z

It was recently removed from the default gems:

…ruby-head build They were recently removed from Ruby's default gems. Ref: https://bugs.ruby-lang.org/issues/17873 Ref: mikel/mail#1439 Ref: teamcapybara/capybara#2468

casperisfine · 2021-05-28T10:02:41Z

Actually this cause double loading warnings for ruby 3.0 and older. I'm not too sure yet how best to fix this.

casperisfine · 2021-05-29T08:03:45Z

David Rodríguez, bundler's maintainer is looking at the issue, I'll keep an eye and report back here when there's a solution: https://bugs.ruby-lang.org/issues/17873#note-18

casperisfine · 2021-07-07T08:33:24Z

So the double loading issue was fixed in rubygems/bundler, we can probably merge this now.

Ref: mikel/mail#1439

net-smtp has been removed from default gems in Ruby 3.1, but it is used by the `mail` gem. Remove when mikel/mail#1439 is fixed

See the following: * rails/rails#42366 * mikel/mail#1439 * https://bugs.ruby-lang.org/issues/17873 In essence, the net/smtp gem config was changed in ruby 3.1 and the mail gem needs to merge in their fix.

casperisfine · 2021-10-12T11:08:30Z

Any news here?

jeremy · 2021-10-18T15:22:11Z

mail.gemspec

  s.add_dependency('mini_mime', '>= 0.1.1')
+  s.add_dependency('net-smtp')
+  s.add_dependency('net-imap')
+  s.add_dependency('net-pop')


Do these gems no-op on older Rubies (1.8, 1.9, etc)?

These gems yes, however they themselves have digest as dependency which is causing some doable loading problem:

/Users/byroot/.gem/ruby/2.7.2/gems/digest-3.0.0/lib/digest.rb:6: warning: already initialized constant Digest::REQUIRE_MUTEX /opt/rubies/2.7.2/lib/ruby/2.7.0/digest.rb:6: warning: previous definition of REQUIRE_MUTEX was here ....

I already submitted the fix in bundler ruby/rubygems#4989, hopefully it should be fixed soon. I totally understand if you want to wait for bundler to fix this first.

I think this is already fixed @jeremy @casperisfine. Can we release this?

Would it make sense to wrap these in an if statement that is only true for Ruby 3.1+?

The problem here is those gems can't be installed on older versions, @casperisfine's reply only shows part of the issue.

For example on 2.0.0:

$ gem i net-smtp Fetching: timeout-0.2.0.gem (100%) Successfully installed timeout-0.2.0 Fetching: io-wait-0.2.1.gem (100%) ERROR: Error installing net-smtp: io-wait requires Ruby version >= 2.6.0. $ gem i net-imap ERROR: Error installing net-imap: io-wait requires Ruby version >= 2.6.0. $ gem i net-pop ERROR: Error installing net-pop: io-wait requires Ruby version >= 2.6.0.

Also #1439 (comment)

@nertzy I am pretty sure that an if statement in a .gemspec ends up getting evaluated at gem release time, and trying to condition on ruby version would end up being on what ruby version is running in the environment doing the gem release, and then fixed in the release.

My understanding is you can't actually do dynamic conditions based on the running environment in a gemspec like that.

Ideally those gems ('net-smtp', 'net-imap' and 'net-pop') would all NOOP when installed on an older unsupported Ruby. That would just solve it for everyone.

So I'm still trying to find solutions upstream, but ultimately would you be open to drop pre 2.5 support to get this moved forward now?

For context, CRuby devs don't seem generally happy to need to explicitly support (even as noop) such old and EOL Ruby versions based on recent discussions, which brings the age-old question: do gems depending on net-* and specifically mail still need to support Ruby <= 2.5 today?

We can still go this way as well.

#1439 (comment)

Bump minor (or major) version and we can still maintain releases compat with <= 2.5 if needed in "legacy" branch.

Btw. I'm happy to help with anything moving this forward.

lewispb · 2021-11-11T10:18:49Z

Could we merge master and add Ruby 3.1 to the GitHub Actions matrix?

It was recently removed from the default gems: - https://bugs.ruby-lang.org/issues/17873 - ruby/ruby#4530

casperisfine · 2021-11-12T09:28:55Z

Hum:

net-imap was resolved to 0.2.2, which depends on
        Ruby (>= 2.5.0)

That's a problem, not sure how we can possibly handle this.

eregon · 2021-11-12T10:45:37Z

If they noop (#1439 (comment)), maybe the required_ruby_version should be lower?

casperisfine · 2021-11-12T10:47:37Z

If they noop

What do you mean?

casperisfine · 2021-11-12T11:06:29Z

Ah nevermind, seems like I didn't properly understand @jeremy's question. They definitely don't noop.

So I don't see how we can support both 3.1 and 2.4

eregon · 2021-11-12T11:11:37Z

A somewhat crazy idea:
Create a new gem, e.g., mail-deps and make two releases:

one release with required_ruby_version < 3.1, and no deps
one release with required_ruby_version >= 3.1, and those 3 deps

Alternatively maybe those 3 gems should really have "empty/noop/using stdlib" releases with required_ruby_version < 2.5, so there is no need to redo something similar manually on top.

eregon · 2022-01-09T13:36:09Z

@pirj That does not work, RubyGems has a single gemspec for a given gem release, it's not evaluated every time bur rather serialized when building a gem.
Also see #1439 (comment)
The only case it might work is with bundler path:/git: but that's obviously just a subset of cases and seens no better than the workaround in #1439 (comment).

mperham · 2022-01-10T17:05:28Z

Does Ruby core know this is a problem? Is there a redmine ticket? They've been very good about compatibility IME and making the gems no-op on older MRI versions seems like a great idea.

We need to remove Ruby 2.5 because the new net-smtp gem is required for the mail gem on Ruby 3.1 but it does not work on <=2.5. mikel/mail#1439 Also remove an anon struct test which now breaks with safe YAML loading on 3.1.

casperisfine · 2022-01-10T17:17:37Z

Is there a redmine ticket?

The closest would be https://bugs.ruby-lang.org/issues/17873, but default gems have their own maintainers, and I think it ultimately fall onto them.

So we should open issues in the three repos:

eregon · 2022-01-10T17:22:37Z

Also io-wait since that's what fails currently: #1439 (comment)

casperisfine · 2022-01-10T19:15:39Z

Indeed. I'll look into it tomorrow unless someone beats me to it.

Ref: mikel/mail#1439 Some gems depend on io-wait, but still support older rubies, so they have to chose between droping support or not listing io-wait. But io-wait could act a a noop on older rubies.

casperisfine · 2022-01-11T15:21:12Z

io-wait PR: ruby/io-wait#9

Ref: mikel/mail#1439 Some gems depend on io-wait, but still support older rubies, so they have to chose between droping support or not listing io-wait. But io-wait could act a a noop on older rubies.

Necessary until mikel/mail#1439 got merged.

deivid-rodriguez · 2022-02-16T18:14:41Z

I think @simi's suggestion at #1439 (comment) is the best way to go. In order to reduce maintainers' burden to implement that solution, I created #1472, including the changes being proposed here.

deivid-rodriguez · 2022-02-16T18:24:23Z

My PR includes a lot of cleanups of old Ruby 1.8 compatibility code that can be now removed. It can be argued that reviewing those changes actually increases maintainers' burden 😅. If that's the case, I'm super happy to remove those cleanups from my PR.

mikel · 2022-04-19T05:36:06Z

Closing this in favour of #1472

casperisfine mentioned this pull request May 28, 2021

Add net-smtp and matrix to the Gemfile to fix the ruby-head build rails/rails#42308

Merged

casperisfine changed the title ~~Add net-smtp as a dependency for Ruby 3.1 compatibility~~ Add former default gems as a dependency for Ruby 3.1 compatibility May 28, 2021

yahonda mentioned this pull request Jun 3, 2021

Add net/smtp gem for bug report templates to support Ruby 3.1 rails/rails#42366

Merged

tagliala added a commit to enriclluelles/route_translator that referenced this pull request Sep 12, 2021

Add net-smtp gem explicitly

90f47b3

Ref: mikel/mail#1439

tagliala mentioned this pull request Sep 12, 2021

Add net-smtp gem explicitly enriclluelles/route_translator#248

Merged

tagliala added a commit to enriclluelles/route_translator that referenced this pull request Sep 12, 2021

Add net-smtp gem explicitly

f873559

net-smtp has been removed from default gems in Ruby 3.1, but it is used by the `mail` gem. Remove when mikel/mail#1439 is fixed

dillonwelch mentioned this pull request Oct 11, 2021

Add fix to ruby-head issue devise-security/devise-security#328

Merged

jeremy reviewed Oct 18, 2021

View reviewed changes

simi approved these changes Oct 24, 2021

View reviewed changes

lewispb mentioned this pull request Nov 9, 2021

Ruby 3.1 compatibility #1461

Closed

byroot added 2 commits November 11, 2021 15:23

Add net-smtp as a dependency for Ruby 3.1 compatibility

9f80a1e

It was recently removed from the default gems: - https://bugs.ruby-lang.org/issues/17873 - ruby/ruby#4530

Also add net-imap and net-pop to the gemspec

651a59a

casperisfine force-pushed the net-smtp-dependency branch from 58704be to 651a59a Compare November 11, 2021 14:23

jeremy assigned eregon and unassigned eregon Jan 11, 2022

casperisfine mentioned this pull request Jan 11, 2022

Make the gem a noop on Rubies older than 2.6 ruby/io-wait#9

Merged

mattbrictson mentioned this pull request Jan 12, 2022

[ruby] Upgrade Ruby to 3.1.0 carbonfive/raygun-rails#652

Closed

tvdeyen added a commit to tvdeyen/alchemy_cms that referenced this pull request Jan 16, 2022

Install net-smtp if using Ruby 3.1

c1ca8a2

Necessary until mikel/mail#1439 got merged.

nholden mentioned this pull request Jan 18, 2022

Add net-http dependency to frameworks using mail rails/rails#44175

Closed

deivid-rodriguez mentioned this pull request Jan 20, 2022

Drop support for Ruby 2.5 activeadmin/activeadmin#7236

Merged

petergoldstein mentioned this pull request Jan 24, 2022

Add Ruby 3.1 and Rails 7.0 to CI ViewComponent/view_component#1254

Merged

hsbt mentioned this pull request Feb 19, 2022

Cannot Load net/smtp ruby/rubygems#5367

Closed

skycat2216 mentioned this pull request Mar 2, 2022

[Bug] Zeitwerk Dependency Required And Wrong Nokogiri installed gushmazuko/metasploit_in_termux#100

Closed

petergoldstein mentioned this pull request Mar 4, 2022

Add Ruby 3.1 and Rails 6.1 and 7 to the CI matrix Shopify/job-iteration#194

Merged

jrochkind mentioned this pull request May 5, 2022

Convert range limit views + helpers to presenters + components projectblacklight/blacklight_range_limit#179

Merged

peteryates mentioned this pull request Jul 20, 2022

Attempted deployment fix by requiring default gems DFE-Digital/npq-registration#471

Merged

mikel mentioned this pull request Nov 30, 2022

Add Ruby 3.1 support to Mail 2.7 branch #1482

Closed

alexdean mentioned this pull request Jan 4, 2023

WIP: try to address warnings about constant redefinitions alexdean/as2#21

Closed

Conversation

casperisfine commented May 28, 2021

Uh oh!

casperisfine commented May 28, 2021

Uh oh!

casperisfine commented May 29, 2021

Uh oh!

casperisfine commented Jul 7, 2021

Uh oh!

casperisfine commented Oct 12, 2021

Uh oh!

jeremy Oct 18, 2021

Choose a reason for hiding this comment

Uh oh!

casperisfine Oct 18, 2021

Choose a reason for hiding this comment

Uh oh!

simi Dec 26, 2021

Choose a reason for hiding this comment

Uh oh!

nertzy Jan 4, 2022

Choose a reason for hiding this comment

Uh oh!

eregon Jan 4, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jrochkind Jan 4, 2022

Choose a reason for hiding this comment

Uh oh!

mikel Feb 2, 2022

Choose a reason for hiding this comment

Uh oh!

casperisfine Feb 2, 2022

Choose a reason for hiding this comment

Uh oh!

eregon Feb 2, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

simi Feb 2, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lewispb commented Nov 11, 2021

Uh oh!

casperisfine commented Nov 12, 2021

Uh oh!

eregon commented Nov 12, 2021

Uh oh!

casperisfine commented Nov 12, 2021

Uh oh!

casperisfine commented Nov 12, 2021

Uh oh!

eregon commented Nov 12, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

eregon commented Jan 9, 2022

Uh oh!

mperham commented Jan 10, 2022

Uh oh!

casperisfine commented Jan 10, 2022

Uh oh!

eregon commented Jan 10, 2022

Uh oh!

casperisfine commented Jan 10, 2022

Uh oh!

casperisfine commented Jan 11, 2022

Uh oh!

deivid-rodriguez commented Feb 16, 2022

Uh oh!

deivid-rodriguez commented Feb 16, 2022

Uh oh!

mikel commented Apr 19, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

eregon Jan 4, 2022 •

edited

Loading

eregon Feb 2, 2022 •

edited

Loading

simi Feb 2, 2022 •

edited

Loading

eregon commented Nov 12, 2021 •

edited

Loading