Skip to content

Drop deprecated qt5_use_modules macro#147

Merged
miek merged 1 commit intomasterfrom
qt_5_11_0_fix
Jun 3, 2018
Merged

Drop deprecated qt5_use_modules macro#147
miek merged 1 commit intomasterfrom
qt_5_11_0_fix

Conversation

@miek
Copy link
Copy Markdown
Owner

@miek miek commented May 31, 2018

Reference: https://doc.qt.io/archives/qt-5.10/cmake-manual.html

This should fix the build failure on Qt 5.11.0, as reported in #146

@miek miek mentioned this pull request May 31, 2018
@apjanke
Copy link
Copy Markdown

apjanke commented Jun 1, 2018

Afraid I'm getting another Qt5 error now, when building against this patch.

$ cmake .
CMake Error at CMakeLists.txt:60 (find_package):
  By not providing "FindQt5Widgets.cmake" in CMAKE_MODULE_PATH this project
  has asked CMake to find a package configuration file provided by
  "Qt5Widgets", but CMake did not find one.

  Could not find a package configuration file provided by "Qt5Widgets" with
  any of the following names:

    Qt5WidgetsConfig.cmake
    qt5widgets-config.cmake

  Add the installation prefix of "Qt5Widgets" to CMAKE_PREFIX_PATH or set
  "Qt5Widgets_DIR" to a directory containing one of the above files.  If
  "Qt5Widgets" provides a separate development package or SDK, be sure it has
  been installed.


-- Configuring incomplete, errors occurred!
See also "/Users/janke/local/repos/inspectrum/CMakeFiles/CMakeOutput.log".

I'm not exactly sure what to do here; if I have time over the weekend I'll look in to it.

@miek miek merged commit d8d5230 into master Jun 3, 2018
miek added a commit that referenced this pull request Jul 8, 2018
@miek miek deleted the qt_5_11_0_fix branch August 26, 2020 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants