Skip to content

[PM-22302] Toolkit: Support fallible inputs#966

Merged
jsidorenko merged 7 commits into
mainfrom
js/support-fallible-inputs
Mar 18, 2026
Merged

[PM-22302] Toolkit: Support fallible inputs#966
jsidorenko merged 7 commits into
mainfrom
js/support-fallible-inputs

Conversation

@jsidorenko

Copy link
Copy Markdown
Contributor

Overview

This PR adds support for fallible inputs when constructing an intent.

The --input-utxo param allows specifying the input id, but doesn't tell where to place them.
To solve that, we read the unshielded_inputs from the both guaranteed and fallible effects and place the inputs accordingly.

📌 Submission Checklist

  • Changes are backward-compatible (or flagged if breaking)
  • Pull request description explains why the change is needed
  • Self-reviewed the diff
  • I have included a change file, or skipped for this reason:
  • If the changes introduce a new feature, I have bumped the node minor version
  • Update documentation (if relevant)
  • Updated AGENTS.md if build commands, architecture, or workflows changed
  • No new todos introduced

🧪 Testing Evidence

Please describe any additional testing aside from CI:

  • Additional tests are provided (if possible)

🔱 Fork Strategy

  • Node Runtime Update
  • Node Client Update
  • Other:
  • N/A

Links

Closes https://shielded.atlassian.net/browse/PM-22302

@jsidorenko jsidorenko requested a review from a team as a code owner March 17, 2026 15:37
@github-actions

Copy link
Copy Markdown
Contributor

kics-logo

KICS version: v2.1.19

Category Results
CRITICAL CRITICAL 0
HIGH HIGH 2
MEDIUM MEDIUM 52
LOW LOW 3
INFO INFO 64
TRACE TRACE 0
TOTAL TOTAL 121
Metric Values
Files scanned placeholder 27
Files parsed placeholder 27
Files failed to scan placeholder 0
Total executed queries placeholder 73
Queries failed to execute placeholder 0
Execution time placeholder 11

@jsidorenko jsidorenko requested a review from ozgb March 17, 2026 15:43
@gilescope

Copy link
Copy Markdown
Contributor

Looks good, can we a test for this additional functionality please?

@jsidorenko jsidorenko enabled auto-merge March 18, 2026 14:16
@jsidorenko jsidorenko added this pull request to the merge queue Mar 18, 2026
Merged via the queue into main with commit 9befa68 Mar 18, 2026
35 checks passed
@jsidorenko jsidorenko deleted the js/support-fallible-inputs branch March 18, 2026 15:38
gilescope pushed a commit that referenced this pull request Apr 8, 2026
@gilescope gilescope added this to the node-1.0.0 milestone Apr 10, 2026
m2ux added a commit that referenced this pull request Apr 23, 2026
Signed-off-by: Mike Clay <mike.clay@shielded.io>
m2ux added a commit that referenced this pull request Apr 23, 2026
Signed-off-by: Mike Clay <mike.clay@shielded.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants