feat: toolkit perf improvements from #820#939
Merged
Conversation
Adds a round-trip test that deserializes a LedgerState via both the standard (two-pass verified) and trusted (single-pass) paths, then asserts they produce identical serialized output. Catches silent divergence if upstream changes its hash function or format.
Use ordered `buffered` stream, collect results into SerializedTxBatches, support inline --transfers JSON arg alongside --transfers-file, and extract transfer spec parsing into BatchSingleTxArgs::get_transfer_specs. This brings `batch_single_tx` in-line with the other toolkit builders
Contributor
|
KICS version: v2.1.19
|
…text tests faster and more useful
…rite; correct changefiles content
Signed-off-by: Giles Cope <gilescope@gmail.com>
m2ux
added a commit
that referenced
this pull request
Mar 24, 2026
Re-apply Result error propagation on top of toolkit perf improvements (#939) which restructured apply_txs_collect_events, verify_state_root, update_dust_from_events, and update_dust_from_block. Keeps rayon parallelism from #939 while converting expect/panic to map_err/? in update_from_block, update_from_tx, apply_txs_collect_events, verify_state_root, and update_ledger_state_from_bytes.
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Building on #820 to make it merge-ready
batch_single_txnow writes to the standard toolkit output file for consistencyArena::hash🗹 TODO before merging
📌 Submission Checklist
🧪 Testing Evidence
Please describe any additional testing aside from CI:
🔱 Fork Strategy
Links